Flyout swaps the attribute selector widget, but not the title select widget. We need to support both widgets.

Bonus: if attribute widget has no attributes, fallback to select.

CommentFileSizeAuthor
#4 2997833-4.patch187.28 KBmglaman
#3 2997833-3.patch181.15 KBmglaman
#2 2997833-2.patch176.41 KBmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new 2997833-2.patch176.41 KB

Here is an initial patch to fix support for products who have multiple variations without attributes.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new 2997833-3.patch181.15 KB

This supports an explicit check at the widget type used. However, we can use this check to simplify the rendering process of the formatter.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new 2997833-4.patch187.28 KB

This fixes an error on add to cart and improves cachability metadata, along with smart normalization of attributes if the widget is not the attributes widget.

rinasek’s picture

rinasek commented

Tested with Commerce Demo and works as expected.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

  • mglaman committed 3555fe5 on 8.x-1.x 
    Issue #2997833 by mglaman, rinasek: Does not support variation title...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Fixed

Merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.