While evaluating this module I noticed that on the Extend page, the project name is in lower case and should be in title case to be consistent with the rest of the project names on the page.
"Capitalize the name of the module, because module names are proper nouns."
https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...
ALSO:
According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | Screen Shot 2018-09-06 at 11.26.34 AM.png | 6.86 KB | alonaoneill |
| #2 | reference_value_pair-capitalize-2997822-2.patch | 430 bytes | volkswagenchick |
Comments
Comment #2
volkswagenchickI uploaded a patch that capitalizes the name of the module on the extend page and addresses the dependency namespacing as per Drupal coding standards.
Thanks!
Comment #3
alonaoneill commentedCode looks good, the name of the module is now capitalized on the Extend page. Screenshot provided."
Marking as RTBC
Thank you for working on module!
Comment #4
chipway commentedPatch applies cleanly and correct the .info.yml file.
It is useful for DrupalCi to download the right dependencies and Installation profiles to work well. So sooner is better.
RTBC +1
Comment #5
miiimooo