Core views facets is a module to extend the functionality of the factes module to use views (not only Search api) with facets.

Project link

https://www.drupal.org/project/core_views_facets

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/core_views_facets.git

Comments

slasher13 created an issue. See original summary.

prethiee’s picture

Issue summary: View changes
gambry’s picture

All looks good from what I can see. The only things I would change is the test module core_views_facets_test_views should be placed inside tests/modules/ directory.

gambry’s picture

Status: Needs review » Needs work
avpaderno’s picture

Priority: Major » Normal

Thank your for your contribution!

We need a project with code committed only from you.
In this project, which is not owned from you, there are 22 commits from you, and 16 commits from the owner. Since the owner is already a vetted user, there isn't the problem that he could need his project to become a vetted user, but still there aren't only your commits, in the code reviewers are going to check.

slasher13’s picture

Status: Needs work » Needs review

#3 done

I don't understand why it is a problem to have 2 maintainers. Can you please explain how a project with 2 maintainers can get security coverage.

avpaderno’s picture

Status: Needs review » Needs work

The purpose of these applications is not changing the status of a project, but giving the users who apply a new role (the vetted role) that allows them to opt into security coverage with any of their projects (the ones they created or the ones they will create).
In these applications, we require the user who created the application show to know how to write Drupal code, and in particular how to write secure code. If the code is written from two or more users, we cannot verify what the user who applied understand of writing Drupal code.

In the specific case, then, the project owner already has the vetted role, which means the project can already be changed to opt into security coverage from the project owner.

christianadamski’s picture

Status: Needs work » Fixed

I altered the setting accordingly, thanks for everyone's effort

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.