Problem/Motivation

"analtics" is misspelled in adobe_analytics_page_bottom here https://cgit.drupalcode.org/adobe_analytics/tree/adobe_analytics.module#n41

Noticed when implementing a module to do some tweaking of that page bottom addition.

Proposed resolution

Fix misspelling.

Remaining tasks

Do it.

User interface changes

None.

API changes

I think technically this is a BC break, but it's still an alpha release, so I think it's OK? If we're really concerned we could continue supporting the misspelling as well as offer the correctly spelt key.

Data model changes

None.

CommentFileSizeAuthor
#2 fix_misspelling-2996606-2.patch539 bytesm4olivei

Comments

m4olivei created an issue. See original summary.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Active » Needs review
StatusFileSize
new fix_misspelling-2996606-2.patch539 bytes

Here is a quick patch. Doesn't try to add BC, just fixes the misspelling, which is probably fine, since this is still alpha.

deviantintegral’s picture

deviantintegral commented
Status: Needs review » Reviewed & tested by the community

IMO breaking APIs in alphas is fine, especially for a fix like this.

kmoll’s picture

kmoll commented

Yup, I think the change is fine. Committing. Thanks!

  • kmoll committed 9fbd942 on 8.x-1.x authored by m4olivei 
    Issue #2996606 by m4olivei: Correct misspelling of "analtics"
kmoll’s picture

kmoll commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.