Argentina postal code formatting update.

Currently: A9999AAA

Needs to be: A9999

Same for version 1.5 and 1.6

Patch to follow.

CommentFileSizeAuthor
#2 2996590-Argentina-formatting-update.patch727 bytesthemic8

Comments

themic8 created an issue. See original summary.

themic8’s picture

StatusFileSize
new727 bytes

Patch attached.

themic8’s picture

Issue summary: View changes
themic8’s picture

Assigned: themic8 » Unassigned
themic8’s picture

Status: Active » Needs review
liam morland’s picture

Thanks for the patch.

The sources I have found tell me that it is correct as it is. Do people sometimes not use the final three letters? Perhaps they should be optional.

There is no point putting {1}; it means the same thing as leaving it out. While we are changing it, it should use \d instead of [0-9].

themic8’s picture

The current configuration is not allowing users to complete their orders due to the validation. This was tested on a live site and blocks users.

liam morland’s picture

Everything I have read about Argentine postal codes matches what is currently there. If it is the case that people are not actually using the last three digits, those can be made optional.

liam morland’s picture

Status: Needs review » Needs work
liam morland’s picture

Version: 7.x-1.5 » 7.x-1.x-dev
themic8’s picture

Liam, Thanks.

liam morland’s picture

Did you want to re-roll this with the last three digits optional?

liam morland’s picture

Status: Needs work » Closed (works as designed)

As far as I can tell, the code is correct as it in. I would be interested in hear from someone with experience with Argentinian postal codes. I'm happy to make fixes as required.