According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/7/creating-custom-modules/writing-module-inf...

Patch to follow...

CommentFileSizeAuthor
#3 lightbox2-update-format-dependencies-12756445-3.patch577 bytesjqtnguyen

Comments

JQTNguyen created an issue. See original summary.

jqtnguyen’s picture

jqtnguyen commented
Issue summary: View changes

Updated OP link to D7 Standards (previous link was D8)

jqtnguyen’s picture

jqtnguyen commented
Assigned: jqtnguyen » Unassigned
Status: Active » Needs review
StatusFileSize
new lightbox2-update-format-dependencies-12756445-3.patch577 bytes

Uploading patch for issue.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community

Dependency namespacing issue was addressed and code looks good. Patch applied via simplytest.me

Marking RTBC

pifagor’s picture

pifagor commented

Look good

pifagor’s picture

pifagor commented
alex_optim’s picture

alex_optim
Location Tallinn
commented

Good for me.

  • voleger committed ff95354 on 7.x-2.x authored by JQTNguyen 
    Issue #2996581 by JQTNguyen, pifagor, volkswagenchick, alex_optim:...
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Reviewed & tested by the community » Fixed

Thanks, pushed in 7.x-2.x-dev

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.