CommentFileSizeAuthor
#5 drupal-n2996519-5.interdiff.txt450 bytesdamienmckenna
#5 drupal-n2996519-5.patch554 bytesdamienmckenna
#3 drupal-n2996519-3.patch486 bytesdamienmckenna

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Apparently one known item remaining:
#2947772-60: Fully support PHP 7.2 in Drupal 7

@ "includes/theme.inc" file.
- $links = $variables['links'];
+ $links = (array) $variables['links'];

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new drupal-n2996519-3.patch486 bytes

Should $attributes be changed too?

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

should probably also do attributes as well.

See the D8 theme.inc
line 552
https://cgit.drupalcode.org/drupal/tree/core/includes/theme.inc#n552

and
line 1569
https://cgit.drupalcode.org/drupal/tree/core/includes/theme.inc#n1569

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new drupal-n2996519-5.patch554 bytes
new drupal-n2996519-5.interdiff.txt450 bytes

With $attributes too.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » Unassigned
Issue tags: +Drupal 7.60 target

Thanks Damien!

pol’s picture

pol
Location Brussels
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs framework manager review, +Pending Drupal 7 commit

Thanks guys !

Pushing this forward now.

fabianx’s picture

fabianx commented
Issue tags: -Needs framework manager review

Lets get this in.

pol’s picture

pol
Location Brussels
commented
Title: Fully support php 7.2 in Drupal core, catch all issue. » PHP 7.2 compatibility - make sure some variables are arrays in theme_links().
pol’s picture

pol
Location Brussels
commented
pol’s picture

pol
Location Brussels
commented

  • Fabianx committed 083a4ec on 7.x 
    Issue #2996519 by DamienMcKenna, joseph.olstad, Pol: PHP 7.2...
fabianx’s picture

fabianx commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks all!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Thanks for the creds! :)
Woot! Yet another core commit!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue tags: -Drupal 7.60 target, -Pending Drupal 7 commit +Drupal 7.61 target

Bumping to 7.61. This didn't make it into 7.60.

Although it is currently in the 7.x branch