Fix docs for ConditionPluginBase

Thanks!

+++ b/core/lib/Drupal/Core/Executable/ExecutableInterface.php
@@ -11,6 +11,9 @@
+   * @throws \Drupal\Core\Executable\ExecutableException

For reference: this mirrors ExecutableManagerInterface::execute().

+++ b/core/lib/Drupal/Core/Executable/ExecutableInterface.php
@@ -11,6 +11,9 @@
+   * @throws \Drupal\Core\Executable\ExecutableException
+   *   If the plugin could not be executed.

I find this all very confusing looking at \Drupal\Core\Condition\ConditionManager::execute() since that calls ->evaluate() and there are no usages of ExecutableException in core.

I'm tempted to mark this as a duplicate of #2385427: Add a ConditionManagerInterface because that issue should really be updating \Drupal\Core\Condition\ConditionPluginBase::setExecutableManager() to typehint on the new ConditionManagerInterface.

I'm tempted to mark this as a duplicate of #2385427: Add a ConditionManagerInterface because that issue should really be updating \Drupal\Core\Condition\ConditionPluginBase::setExecutableManager() to typehint on the new ConditionManagerInterface.

In #2385427-29: Add a ConditionManagerInterface you observed changing the type hint in BlockForm would be a BC break. That class is explicitly marked internal, and if I understand our BC policy correctly, plugin classes are internal as well. Could you help me understand the difference between both cases? :)

Here's the absolute minimum for this issue, together with #3065586: ConditionManager::execute() implementation doesn't conform to the interface it would make it much easier to understand the code flow of the condition plugins.

#8 looks great - if someone could rtbc it then I'd commit it.

Committed and pushed 7daf1e6988 to 8.8.x and 82731b8283 to 8.7.x. Thanks!

Backported as this is a docs only change.