Closed (fixed)
Project:
Elevate Image Zoom
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Aug 2018 at 11:28 UTC
Updated:
20 Sep 2018 at 07:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
abhaypai commentedAdding Readme file;
Sorry! well am newbie in this type of commits; starting to contribute to Opensource now.
well am not sure why my diff file was not showing any content inside it. so i added 2 file in this comment; one is Readme.txt and other is patch file.
Any explanation to understand this will be helpful.
Thanks.
Comment #3
brahmjeet789 commented@paiabhay8 : i added a patch for the same please review it and for creating patch you can use this link https://www.drupal.org/node/707484
Comment #4
msankhala commentedIt should be `CONTENT OF THIS FILE` also there should be single empty line after this heading.
trailing spaces.
Line length should not exceed 80 characters per line.
No single new line at the end of file.
See https://www.drupal.org/docs/develop/documenting-your-project/readme-temp... for guidance.
Comment #5
msankhala commentedComment #6
abhaypai commentedThanks @brahmjeet789 for the reference documentation on adding new file for the patch.
Review of your file on Comment #3; i can probaly say that you need to take look at this link https://www.drupal.org/node/2181737
It has some standards states that your line on columns should not exceed 80, etc.
(note:- all unwanted files are hided on my commits now.)
Comment #7
abhaypai commentedPlease review this patch now. Hope so this time it is good.
Comment #8
keshavv commented