Comments

Akshay kashyap created an issue. See original summary.

abhaypai’s picture

Status: Needs work » Needs review
StatusFileSize
new0 bytes
new1.02 KB

Adding Readme file;

Sorry! well am newbie in this type of commits; starting to contribute to Opensource now.
well am not sure why my diff file was not showing any content inside it. so i added 2 file in this comment; one is Readme.txt and other is patch file.

Any explanation to understand this will be helpful.

Thanks.

brahmjeet789’s picture

StatusFileSize
new1.02 KB

@paiabhay8 : i added a patch for the same please review it and for creating patch you can use this link https://www.drupal.org/node/707484

msankhala’s picture

  1. +++ b/README.txt
    @@ -0,0 +1,39 @@
    +CONTENTS
    

    It should be `CONTENT OF THIS FILE` also there should be single empty line after this heading.

  2. +++ b/README.txt
    @@ -0,0 +1,39 @@
    + * INSTALLATION ¶
    

    trailing spaces.

  3. +++ b/README.txt
    @@ -0,0 +1,39 @@
    +Elevate image zoom provides a field formatter that allows you to apply it to your image field. This will provide different types of image zoom features.
    

    Line length should not exceed 80 characters per line.

  4. +++ b/README.txt
    @@ -0,0 +1,39 @@
    + ¶
    \ No newline at end of file
    

    No single new line at the end of file.

See https://www.drupal.org/docs/develop/documenting-your-project/readme-temp... for guidance.

msankhala’s picture

Status: Needs review » Needs work
abhaypai’s picture

Status: Needs work » Needs review
StatusFileSize
new1.37 KB

Thanks @brahmjeet789 for the reference documentation on adding new file for the patch.

Review of your file on Comment #3; i can probaly say that you need to take look at this link https://www.drupal.org/node/2181737
It has some standards states that your line on columns should not exceed 80, etc.

(note:- all unwanted files are hided on my commits now.)

abhaypai’s picture

StatusFileSize
new1.37 KB

Please review this patch now. Hope so this time it is good.

keshavv’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.