Handle currency and tax components to prepare price [#2995988]

Hi,

thanks for this gorgeous module.

I found a bug if started using this module with hungarian forint (HUF) because this currency decimals is 0.

It is more complex problem than I check it first time. The module not handle tax price component and currencies.

Regards,
Joe

Comment	File	Size	Author
#8	bad_price_if_currency_decimals_is_not_2_2995988_8.patch	10.53 KB	dj1999
#7	bad_price_if_currency_decimals_is_not_2_2995988_7.patch	10.47 KB	dj1999
#5	bad_price_if_currency_decimals_is_not_2_2995988_5.patch	9.76 KB	dj1999
#4	bad_price_if_currency_decimals_is_not_2_2995988_3.patch	9.41 KB	dj1999
#2	bad_price_if_currency_decimals_is_not_2_2995988.patch	847 bytes	dj1999
	bad_price_if_currency_decimals_is_not_2.patch	804 bytes	dj1999

Comments

Comment #1

29 August 2018 at 18:52

dj1999 created an issue. See original summary.

Status	File	Size
new	bad_price_if_currency_decimals_is_not_2_2995988.patch	847 bytes

Status	File	Size
hidden	bad_price_if_currency_decimals_is_not_2.patch	804 bytes

Comment #3

dj1999 commented 30 August 2018 at 11:16

Title:	Bad price if currency decimals is not 2	» Handle currency and tax components to prepare price
Issue summary:	View changes

1 file was hidden/shown/deleted

Status	File	Size
hidden	bad_price_if_currency_decimals_is_not_2_2995988.patch	847 bytes

Comment #4

dj1999 commented 30 August 2018 at 11:23

Status	File	Size
new	bad_price_if_currency_decimals_is_not_2_2995988_3.patch	9.41 KB

I prepared a bigger patch for handle currency and tax component the commerce price.
Added an update hook for install file to prepare new column the product_price_list table and prepare some index too.

Be careful on production site because after database update will run a script on table and change all prices to commerce price format base on currency decimal.