According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#6 Update_dependencies_format_in_info.yml_2995718-6.patch691 byteschipway
#2 cms_core-info-fix-2995718-2.patch621 bytesalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
StatusFileSize
new cms_core-info-fix-2995718-2.patch621 bytes

I uploaded a patch that corrects the dependency namespacing in the .info.yml file.
Thanks!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Active » Reviewed & tested by the community

Code looks good. Patch applied via simplytest.me. I compared file to core modules and the dependency namespacing issue has been addressed.

Marking RTBC

chipway’s picture

chipway commented
Status: Reviewed & tested by the community » Needs work

Thanks for the patch, but it is wrong for libraries for example. Please rework.

chipway’s picture

chipway commented
Assigned: alonaoneill » Unassigned
chipway’s picture

chipway commented
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_2995718-6.patch691 bytes

Here is the fixed patch. Please review.

jurriaanroelofs’s picture

jurriaanroelofs commented
Status: Needs review » Fixed

thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.