testViewsGetHandler() says:

   * Tests the views_get_handler method.
   *
   * @see views_get_handler()

But that function no longer exists. Instead, this is testing ViewsHandlerManager::getHandler().

CommentFileSizeAuthor
#6 2995231-6.patch671 byteshardikpandya
#2 fix-outdated-doc-testViewsGetHandler-2995231-2.patch647 bytesmsankhala

Comments

joachim created an issue. See original summary.

msankhala’s picture

msankhala commented
Status: Active » Needs review
StatusFileSize
new fix-outdated-doc-testViewsGetHandler-2995231-2.patch647 bytes

Here is the patch

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you @msankhala!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/views/tests/src/Kernel/ModuleTest.php
@@ -37,9 +37,9 @@ class ModuleTest extends ViewsKernelTestBase {
-   * Tests the views_get_handler method.
+   * Tests the views get handler.
...
+   * @see \Drupal\views\Plugin\ViewsHandlerManager::getHandler().

It's still testing the method. This should be something like;
Tests the ViewsHandlerManager::getHandler() method.

hardikpandya’s picture

hardikpandya commented
Assigned: Unassigned » hardikpandya
hardikpandya’s picture

hardikpandya commented
Assigned: hardikpandya » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2995231-6.patch671 bytes

Please find the updated patch file

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Looks good! Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 887e1dcd24 to 8.7.x and a8364dabc3 to 8.6.x. Thanks!

----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 42 | ERROR | [x] Trailing punctuation for @see references is not
    |       |     allowed.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

diff --git a/core/modules/views/tests/src/Kernel/ModuleTest.php b/core/modules/views/tests/src/Kernel/ModuleTest.php
index 5a47e6b1c7..1333c6225b 100644
--- a/core/modules/views/tests/src/Kernel/ModuleTest.php
+++ b/core/modules/views/tests/src/Kernel/ModuleTest.php
@@ -39,7 +39,7 @@ class ModuleTest extends ViewsKernelTestBase {
   /**
    * Tests the  ViewsHandlerManager::getHandler() method.
    *
-   * @see \Drupal\views\Plugin\ViewsHandlerManager::getHandler().
+   * @see \Drupal\views\Plugin\ViewsHandlerManager::getHandler()
    */
   public function testViewsGetHandler() {
     $types = ['field', 'area', 'filter'];

Fixed on commit.

  • alexpott committed 887e1dc on 8.7.x 
    Issue #2995231 by hardik.p, msankhala, joachim, alexpott: outdated docs...

  • alexpott committed a8364da on 8.6.x 
    Issue #2995231 by hardik.p, msankhala, joachim, alexpott: outdated docs...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.