I have a minor issue when I run the landing page through Chrome's lighthouse auditing testsuite.
The Accessibility score is 95/100
Its fails as the SVG in drupal/core/profiles/demo_umami/themes/umami/images/svg/search.svg
is parsed... here is the error message
attributes on the page are not unique
many items in here have a id="Oval'
It is a quick fix to get 100/100 by deleting the Id's all together.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | umami-demo-d8.patch | 7.1 KB | MaddieC |
| #2 | searchIcon-2994976-2.patch | 4.03 KB | martin107 |
Comments
Comment #2
martin107 commentedHere is the patch
Comment #3
martin107 commentedComment #4
markconroy commentedAfter applying this patch and running Lighthouse again, we get the same error. It looks like there are also some
id="shape"It might be best to run the SVG through SVGOMG here https://jakearchibald.github.io/svgomg/
Comment #5
MaddieC commentedComment #6
MaddieC commentedRemoved the "shape" ids.
Comment #7
MaddieC commentedComment #8
markconroy commentedYippee! Another patch is now RTBC
Comment #11
lauriiiCommitted 061c632 and pushed to 8.7.x and cherry-picked to 8.6.x. Thanks!
Comment #12
andrewmacpherson commentedPlease remember to tag accessibility issues. One day we might make a big chart of all the a11y things we fixed :-)
In practice, duplicate IDs only cause a problem when another element is pointing to them, with a
<label for>, or tableheadersattribute, say. All the same, technically it's WCAG failure F77: Failure of Success Criterion 4.1.1 due to duplicate values of type ID. Good catch!Awesome, I just ran the aXe/Lighthouse checks to confirm it - 100/100 indeed. Well done team!