I have a minor issue when I run the landing page through Chrome's lighthouse auditing testsuite.

The Accessibility score is 95/100

Its fails as the SVG in drupal/core/profiles/demo_umami/themes/umami/images/svg/search.svg

is parsed... here is the error message

attributes on the page are not unique

many items in here have a id="Oval'

It is a quick fix to get 100/100 by deleting the Id's all together.

CommentFileSizeAuthor
#6 umami-demo-d8.patch7.1 KBMaddieC
#2 searchIcon-2994976-2.patch4.03 KBmartin107

Comments

martin107 created an issue. See original summary.

martin107’s picture

martin107 commented
Assigned: martin107 » Unassigned
Issue tags: +Quick fix
StatusFileSize
new searchIcon-2994976-2.patch4.03 KB

Here is the patch

martin107’s picture

martin107 commented
Issue summary: View changes
markconroy’s picture

markconroy commented
Status: Active » Needs work

After applying this patch and running Lighthouse again, we get the same error. It looks like there are also some id="shape"

It might be best to run the SVG through SVGOMG here https://jakearchibald.github.io/svgomg/

MaddieC’s picture

MaddieC commented
Assigned: Unassigned » MaddieC
MaddieC’s picture

MaddieC commented
StatusFileSize
new umami-demo-d8.patch7.1 KB

Removed the "shape" ids.

MaddieC’s picture

MaddieC commented
Assigned: MaddieC » Unassigned
Status: Needs work » Needs review
markconroy’s picture

markconroy commented
Status: Needs review » Reviewed & tested by the community

Yippee! Another patch is now RTBC

  • lauriii committed 061c632 on 8.7.x 
    Issue #2994976 by martin107, MaddieC, markconroy: Search icon: Remove...

  • lauriii committed f3fdd3d on 8.6.x 
    Issue #2994976 by martin107, MaddieC, markconroy: Search icon: Remove...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 061c632 and pushed to 8.7.x and cherry-picked to 8.6.x. Thanks!

andrewmacpherson’s picture

andrewmacpherson commented
Issue tags: +Accessibility

Please remember to tag accessibility issues. One day we might make a big chart of all the a11y things we fixed :-)

In practice, duplicate IDs only cause a problem when another element is pointing to them, with a <label for>, or table headers attribute, say. All the same, technically it's WCAG failure F77: Failure of Success Criterion 4.1.1 due to duplicate values of type ID. Good catch!

It is a quick fix to get 100/100 by deleting the Id's all together.

Awesome, I just ran the aXe/Lighthouse checks to confirm it - 100/100 indeed. Well done team!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.