Prepare the module for a stable release.

Tasks include

* Refactor to clean up service definitions
* Run phpcs
* Add more test coverage

Patches to finish/re-roll:
#2971795: Negotiated rates cannot be returned without a valid account number
#2960549: Weight and Dimensions Validation is necessary
#2912549: Add UPS Sure Post service
#2918813: Implement SupportsTrackingInterface to provide tracking url support

CommentFileSizeAuthor
#2 commerce_ups-prepare_for_8_release-2994727.patch20.63 KBandyg5000

Comments

andyg5000 created an issue. See original summary.

andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
StatusFileSize
new commerce_ups-prepare_for_8_release-2994727.patch20.63 KB

Here's a big patch that includes the punch-list items above as well as refactoring to expose the UPS classes to Drupal's service container. This allows them to be swapped out or decorated by other modules.

There should be no breaking changes for people using the existing -dev branch. However, people who've customized things or written patches will need to re-roll them.

andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
Status: Active » Needs review
andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
Issue summary: View changes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/src/UPSShipment.php
@@ -66,12 +85,12 @@ class UPSShipment extends UPSEntity {
-    $from_address->setCity($address->getDependentLocality());
+    $from_address->setCity($address->getLocality());

Good catch!

I had a run through of the patch and everything looked on target. Thanks for more tests!

  • andyg5000 committed 0e78a4b on 8.x-3.x 
    Issue #2994727 by andyg5000: Prepare 8.x-1.0 release
andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented

The new tests lead me to that gem ;) Thanks for the review!

andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
Title: Prepare 8.x-1.0 release » Refactor 8.x-3.0 for release
Status: Reviewed & tested by the community » Fixed
andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented

Created #2995607: Roll 8.x-3.0 for release [meta] as the meta issue to track related issues for release so this one can be closed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.