It is an edge case, but nevertheless:
When you book an appointment, stop at the confirmation page, cancel that appointment in another window, and than reload the conformation page, the site breaks.

CommentFileSizeAuthor
#7 dvg_appointment_reload_canceled_submission-2994538-7.patch1.82 KBjoshahubbers
#3 dvg_appointment_reload_canceled_submission-2994538-3.patch1.77 KBjoshahubbers

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
Issue summary: View changes
joshahubbers’s picture

joshahubbers commented
StatusFileSize
new dvg_appointment_reload_canceled_submission-2994538-3.patch1.77 KB

This patch will catch the error, and report it to the watchdog.
There are also two webform notices thrown because we try to load a removed submission. But I think this is such an edge case that these notices can be ignored.

paulvandenburg’s picture

paulvandenburg commented
Status: Needs review » Needs work

Looks good and functionally works fine, but I have 2 minor remarks about the code:

  • You are using the short array syntax, which however nice shouldn't be used yet for this older module.
  • The drupal_goto() is hard mapped to an url that is not guaranteed to be correct. Better would be to use a node/nid path, where the nid can be found in a functional_content vset.
joshahubbers’s picture

joshahubbers commented

Fixed Pauls remarks

joshahubbers’s picture

joshahubbers commented
Status: Needs work » Needs review
joshahubbers’s picture

joshahubbers commented
StatusFileSize
new dvg_appointment_reload_canceled_submission-2994538-7.patch1.82 KB

Upload went wrong...

paulvandenburg’s picture

paulvandenburg commented
Status: Needs review » Reviewed & tested by the community

Looks good, works great.

  • paulvandenburg committed 9d4688f on 7.x-1.x 
    Issue #2994538 by JoshaHubbers: Reloading a confirmation page when the...
paulvandenburg’s picture

paulvandenburg commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.