Problem/Motivation

It is not possible to extend Drupal\Core\Extension\ExtensionDiscovery's scan directories in case you need to put yours extension to non-default location.

Example use case
When you may need to have a lot of groups of modules&themes (100+), in a specific folders, with a single profile, and in single repository (without submodules): it helps to restrict access to specific categories of extensions to different groups of developers. Default extension directories are in read-only mode.

Example directory structure:

root/some_folder
                ├──group1
                        ├──modules
                        ├──themes
                ├──group2
                        ├──modules
                        ├──themes

Proposed resolution

Allow to extend scan directories via adding $settings['extension_discovery_include_directory'] = 'some/folder'; in settings.php

We can extend Drupal\Core\Extension\ExtensionDiscovery, scan method:

    // Allow to extend search directories via settings.php.
    if ($include_directory = Settings::get('extension_discovery_include_directory')) {
      $searchdirs[static::ORIGIN_INCLUDE_DIRECTORY] = $include_directory;
    }
CommentFileSizeAuthor
#8 2994152-8.patch2.3 KBshubham.prakash
#2 extension_discovery_include_directory-2994152-2.patch2.47 KBalexandrdnlv

Comments

alexandrdnlv created an issue. See original summary.

alexandrdnlv’s picture

alexandrdnlv commented
StatusFileSize
new extension_discovery_include_directory-2994152-2.patch2.47 KB

Suggested patch attached.

alexandrdnlv’s picture

alexandrdnlv commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Needs issue summary update

@alexandrdnlv If you provide an issue summary like that it would be nice to explain WHY you need some specific feature. For the thing you want to achieve, there might be a better solution out there.

alexandrdnlv’s picture

alexandrdnlv commented
Issue summary: View changes

Updated a bit issue summary with example use case.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#2783389: There should be a way to add to the RecursiveExtensionFilterIterator whitelist
shubham.prakash’s picture

shubham.prakash commented
StatusFileSize
new 2994152-8.patch2.3 KB

This patch should apply cleanly.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

This was previously tagged or issue summary update which still need to happen.

Even though majority of this patch is comments think it will still need a test case to show it working.

Thanks.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.