Comments

swati.nuna created an issue. See original summary.

minakshiPh’s picture

Status: Needs review » Needs work

Hi @swati.nuna,

The patch is showing a warning of file permissions

$ git apply --check resolved_coding_standard_issues.patch
warning: adstxt_logs.module has type 100644, expected 100755

Please check

johnny_aroza’s picture

Assigned: Unassigned » johnny_aroza
Status: Needs work » Needs review
StatusFileSize
new9.67 KB

minakshiph i have fixed the coding standrd issue

johnny_aroza’s picture

StatusFileSize
new9.67 KB
ajaybmishra’s picture

StatusFileSize
new5.58 KB

Hello,

Find attached updated code with Coding standard fix, please review.

ajaybmishra’s picture

Assigned: johnny_aroza » ajaybmishra
deepanker_bhalla’s picture

StatusFileSize
new25.99 KB
new16.39 KB

@johnny_aroza: I applied your patch #4 to which it applied successfully but some of the issues were left to which i am updating the patch with the consolidated issues.

@ajaybmishra25: Your patch was containing only install as well as module file. Thus the other two files were not there. And also plz make the patches when you are in the module directory as your patch was to be applied in the project root directory.

ajaybmishra’s picture

@deepanker_bhalla : I appreciate your coding standard findings for two more files (adstxtlogs.info & adstxtlogs.css file). Thanks for guiding, for creating patches from module directory for a patch to be applied on module.

volkswagenchick’s picture

Issue tags: +sfdug
volkswagenchick’s picture

Issue tags: +dcnj19, +fldc19
volkswagenchick’s picture

patelmayank7552’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new45.28 KB

Hi,

@deepanker_bhalla. I have checked the patch given by you it's working fine.
Able to apply the patch successfully with no errors.

Attaching the screenshot after applying the patch.

Thanks.