Reviewed & tested by the community
Project:
AdsTxtLogs
Version:
7.x-2.0
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
20 Aug 2018 at 06:21 UTC
Updated:
6 May 2019 at 13:46 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
minakshiPh commentedHi @swati.nuna,
The patch is showing a warning of file permissions
Please check
Comment #3
johnny_aroza commentedminakshiph i have fixed the coding standrd issue
Comment #4
johnny_aroza commentedComment #5
ajaybmishra commentedHello,
Find attached updated code with Coding standard fix, please review.
Comment #6
ajaybmishra commentedComment #7
deepanker_bhalla commented@johnny_aroza: I applied your patch #4 to which it applied successfully but some of the issues were left to which i am updating the patch with the consolidated issues.
@ajaybmishra25: Your patch was containing only install as well as module file. Thus the other two files were not there. And also plz make the patches when you are in the module directory as your patch was to be applied in the project root directory.
Comment #8
ajaybmishra commented@deepanker_bhalla : I appreciate your coding standard findings for two more files (adstxtlogs.info & adstxtlogs.css file). Thanks for guiding, for creating patches from module directory for a patch to be applied on module.
Comment #9
volkswagenchickComment #10
volkswagenchickComment #11
volkswagenchickComment #12
patelmayank7552 commentedHi,
@deepanker_bhalla. I have checked the patch given by you it's working fine.
Able to apply the patch successfully with no errors.
Attaching the screenshot after applying the patch.
Thanks.