API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

Enter a descriptive title (above) relating to protected function EntityStorageBase::invokeHook, then describe the problem you have found:

    // Modules might need to add or change the data initially held by the new
    // entity object, for instance to fill-in default values.
    $this->invokeHook('create', $entity);

Comments

joachim created an issue. See original summary.

msankhala’s picture

Status: Active » Needs review
StatusFileSize
new679 bytes

Here is the patch.

joachim’s picture

It looks like that line is now longer than 80 chars?

mradcliffe’s picture

Issue tags: +vcd2018

I think it's exactly 80 characters. The phpcs job didn't find any errors and checked that file specifically.

mradcliffe’s picture

Issue tags: -vcd2018

Removed tag. Didn't mean to add it to this issue.

joachim’s picture

Status: Needs review » Reviewed & tested by the community

Ok in that case, I think this is RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: invoke-hook-doc-create-op-2993330-2.patch, failed testing. View results

msankhala’s picture

Status: Needs work » Reviewed & tested by the community

Test bot hickup. Moving this to RTBC again.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed 70fed9cbbd to 8.7.x and 21f727eae0 to 8.6.x. Thanks!

  • alexpott committed 70fed9c on 8.7.x
    Issue #2993330 by msankhala, joachim: invokeHook() missing mention of '...

  • alexpott committed 21f727e on 8.6.x
    Issue #2993330 by msankhala, joachim: invokeHook() missing mention of '...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.