The function _tac_lite_user_tids() needs a little cleanup. The for loop shouldn't exist, as the specific scheme is passed in as a parameter. Also, passing in $config is meaningless as it isn't used.

Patch to follow.

CommentFileSizeAuthor
#3 tac_lite-function_cleanup-2992433-3.patch2.71 KBbdlangton
#2 tac_lite-function_cleanup-2992433-2.patch2.71 KBbdlangton

Comments

bdlangton created an issue. See original summary.

bdlangton’s picture

bdlangton commented
Status: Active » Needs review
StatusFileSize
new tac_lite-function_cleanup-2992433-2.patch2.71 KB
bdlangton’s picture

bdlangton commented
StatusFileSize
new tac_lite-function_cleanup-2992433-3.patch2.71 KB

The previous patch doesn't apply. Here's a reroll.

bohus ulrych’s picture

bohus ulrych
Location Pilsen (Czechia)
commented

Thank you very much @bdlangton !
Your patch #3 still works with tac_lite 8.x-1.5 and Drupal 9.3.2

Without this patch is functionality broken. I have two Schemas - one for view and second for update. I've granted only scheme which controls grant_view. But I was able to edit the node which I supposed only to view!
After applying patch I can't edit such node.

grndlvl’s picture

grndlvl commented
Status: Needs review » Fixed

Added to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.