Remove the field_author from Umami recipe content type

We created this originally to link to an "author" content type, so we could:

1. Have guest authors who do not have an account
2. Have more than one author for a post
3. Create lists of authors
4. See "more from this author"
5. Etc

Since it's not being used (and is only referencing the user field anyway, let's remove it. We can add it again later if we have enough content to justify it.

Here's a patch to remove the field_author from the recipe content type.

All field configuration has been removed and looks good.
However 2 related files still mention/expect it:

Drupal\demo_umami_content\InstallHelper::importRecipes lines 202-206
core/profiles/demo_umami/modules/demo_umami_content/default_content/recipes.csv - every item has an author.

The author in the recipes.csv could probably be left as long as it isn't used/checked in InstallHelper::importRecipes()

Agree with @NickWilde.

Tested on local. Works fine for me. No issues during install. Recipe page looks okay.

The only change I'd recommend would be to remove Line no. 205 in InstallHelper::importRecipes(). If the whole 202-206 section is removed then.. the recipes would be authored as an anonymous. The Article & basic content imports have their "UID" setup.

Then as Jay said, just removing line 205 from InstallHelper::importRecipes() should be adequate

Hello everyone,
Here is the patch to resolve the above mentioned issue.

Hi @rahulrasgon,

#10 does the required changes. But it does not Include #3. Coul you please re upload a new patch including changes of both #3 and #10?

Thanks !!

Here's a patch that combines #3 and #10 and also an interdiff.

#12 works perfect !! Thanks @markconroy! Marking it as RTBC.

EDIT: There are some comments which need to be corrected. Like we have a same comment repeated thrice "// Set article author." in InstallHelper.php when setting author for Article, Recipe & Page content types. This doesn't seem to be part of the scope of this ticket, or maybe we create a new ticket?

RTBC + 1.

Just a reroll of #12 so that it gets pass again without any error I hope..

hi @Vidushi Mehta,
If you could add an interdiff.txt to see the difference since the last patch.
Thanks :)

Hi @JayKandari

There's no difference in #12 and #16 its just a reroll of #12 so that the test gets pass again and someone can review.

Thanks :)

Committed 6381b01 and pushed to 8.7.x. Thanks!

This looks good. I checked out the comment #13 and the additional work. For me

        // Set article author.
        if (!empty($data['author'])) {
          $values['uid'] = $this->getUser($data['author']);
        }

For me the comment is fine. On a lot of Drupal sites the node uid value is the author - in fact in the template you get author_* variables based on the user entity so this looks good.

I've only committed this to 8.7.x as it is not a bug fix and is a task.

Discussed with @Gábor Hojtsy who pointed out that this should be backported to 8.6.x because

Umami should always be the best in the current patch release it can be