Problem/Motivation

Footnotes module ships with build-in FakeObjects CKEditorPlugin. But since we are having "FakeObjects CKEditorPlugin" as a separate project we should remove this plugin and add Fakeobjects module as a dependency.

Proposed resolution

- remove build-in FakeObjects CKEditorPlugin.
- add Fakeobjects module as a dependency.
- write hook_requirements.
- ensure that these updates won't bring a problem for the existing sites, that are using 8.2.1 version of the module.
- write UI tests.

Comments

aaronbauman created an issue. See original summary.

id.aleks’s picture

id.aleks commented
Assigned: Unassigned » id.aleks
id.aleks’s picture

id.aleks commented
Title: Remove FakeObjects CKEditorPlugin; add dependency on fakeobjects module; remove dialog and footnotes sources; use libraries instead. » Remove build-in FakeObjects CKEditorPlugin.
Related issues: +#3083800: Add test coverage for the Footnotes CKEditor plugin functionality.

.

id.aleks’s picture

id.aleks commented
Issue summary: View changes
id.aleks’s picture

id.aleks commented
Related issues: +#3083886: Add hook_requirements., +#3083791: Footnotes CKEditor plugin should extend CKEditorPluginBase instead of PluginBase class., +#3083805: Fix coding standards.
id.aleks’s picture

id.aleks commented
Related issues: -#3083800: Add test coverage for the Footnotes CKEditor plugin functionality., -#3083886: Add hook_requirements., -#3083791: Footnotes CKEditor plugin should extend CKEditorPluginBase instead of PluginBase class., -#3083805: Fix coding standards.

  • id.aleks committed 08702c8 on 8.x-2.x 
    Issue #2991458 by id.aleks, AaronBauman: Remove build-in FakeObjects...
pifagor’s picture

pifagor commented
Status: Active » Fixed
pifagor’s picture

pifagor commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.