Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
3 Aug 2018 at 08:55 UTC
Updated:
8 Oct 2018 at 05:29 UTC
Jump to comment: Most recent
Comments
Comment #2
avpadernoComment #3
manish34jain commentedHello montesajudy,
Please run automated review and check the errors.
- Git default branch is not set
- Your README.md does not follow best practices
Here is the report. https://pareview.sh/pareview/https-git.drupal.org-project-reg_confirm_em...
Thanks
Comment #4
avpadernoComment #5
montesajudy commentedThank you very much for your comments and code reviews guys.
I'm working on fixing the coding standard issues.
This is my very first module, though it's functionality is quite simple, I'd be very happy to see this module with a green shield icon above the download link :D
Comment #6
montesajudy commentedHi guys, Thank you very much again for the quick review.
I ran the automated testing multiple times and fixed all the issues as stated, I also added the git default branch.
Comment #7
montesajudy commentedComment #8
avpadernoComment #9
montesajudy commentedkiamlaluno, what's the next step I should do after this code review? When should we mark this as fixed?
Thanks again
Comment #10
avpadernoThe applications are marked as Fixed only when the vetted role has been assigned to the applicant user. The next step is now waiting for reviewers, who will review the code and change the status basing on what they find.
Comment #11
montesajudy commentedThanks again kiamlaluno
Comment #12
avpadernoTo the reviewers: Please change the priority to Normal after reviewing the code.
Comment #13
avpadernoPAReview reports just few errors that for me aren't application-blockers. I will make a manual review later today (if not in the afternoon, in the evening).
Comment #14
avpadernoI will approve the application this evening (about three hours from now).
Comment #15
avpadernoThank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #16
montesajudy commented@kiamlaluno wow this is so awesome! Thank you very much everyone.
Does this mean the module page will have the green secured icon?
Comment #17
avpaderno@montesajudy You need to edit the project.
Comment #18
montesajudy commentedIs that so? thank you very much.
Comment #19
montesajudy commentedThank you very much. It has the green badge now. Thanks a bunch!