This modules extracts LoginToboggan's email confirmation feature. It adds a confirm email address field under email address field in the registration form.

If you want your users to rewrite their email address during registration but don't want to install the whole LoginToboggan module, then this module is for you.

Usage

  1. Download, install and enable the module
  2. Go to "admin/config/people/accounts"
  3. Enable confirm email by ticking the "Use two e-mail fields on registration form" under "Confirm email address"

Project link

https://www.drupal.org/project/reg_confirm_email

Git instructions

git clone --branch 7.x-1.x https://git.drupal.org/project/reg_confirm_email.git

Comments

montesajudy created an issue. See original summary.

avpaderno’s picture

Issue summary: View changes
manish34jain’s picture

Hello montesajudy,

Please run automated review and check the errors.
- Git default branch is not set
- Your README.md does not follow best practices
Here is the report. https://pareview.sh/pareview/https-git.drupal.org-project-reg_confirm_em...

Thanks

avpaderno’s picture

Status: Needs review » Needs work
montesajudy’s picture

Thank you very much for your comments and code reviews guys.
I'm working on fixing the coding standard issues.
This is my very first module, though it's functionality is quite simple, I'd be very happy to see this module with a green shield icon above the download link :D

montesajudy’s picture

Hi guys, Thank you very much again for the quick review.
I ran the automated testing multiple times and fixed all the issues as stated, I also added the git default branch.

montesajudy’s picture

Status: Needs work » Fixed
avpaderno’s picture

Status: Needs work » Needs review
montesajudy’s picture

kiamlaluno, what's the next step I should do after this code review? When should we mark this as fixed?
Thanks again

avpaderno’s picture

The applications are marked as Fixed only when the vetted role has been assigned to the applicant user. The next step is now waiting for reviewers, who will review the code and change the status basing on what they find.

montesajudy’s picture

Thanks again kiamlaluno

avpaderno’s picture

Priority: Normal » Critical

To the reviewers: Please change the priority to Normal after reviewing the code.

avpaderno’s picture

Assigned: Unassigned » avpaderno

PAReview reports just few errors that for me aren't application-blockers. I will make a manual review later today (if not in the afternoon, in the evening).

avpaderno’s picture

Priority: Critical » Normal
Status: Needs review » Reviewed & tested by the community

I will approve the application this evening (about three hours from now).

avpaderno’s picture

Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

montesajudy’s picture

@kiamlaluno wow this is so awesome! Thank you very much everyone.
Does this mean the module page will have the green secured icon?

avpaderno’s picture

@montesajudy You need to edit the project.

montesajudy’s picture

Is that so? thank you very much.

montesajudy’s picture

Thank you very much. It has the green badge now. Thanks a bunch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.