Problem/Motivation

I created a comment word filter, and ran into a problem when I wanted to change the content of the "Unapproved comments" list under "Content > Comments".
It would be helpful if the content of this unapproved comment list could be altered by other modules.

Proposed resolution

A Drupal\comment\Event\CommentAdminOverviewQueryEvent::EVENT_COMMENT_QUERY event is dispatched before querying for comments.
The event contains the query.

Remaining tasks

  • Check whether or not this changed is desired
  • Review code
  • Add test coverage
  • Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#9 reroll_diff_2990248_2-9.txt2.6 KBankithashetty
#9 2990248-9.patch4.53 KBankithashetty
#8 make_comment_admin_overview_query_alterable-2990248-2.patch3.21 KBnemanja
#2 make_comment_admin_overview_query_alterable-2990248-1-8.5.6.patch4.51 KBorlando.thoeny
#2 make_comment_admin_overview_query_alterable-2990248-1-8.6.x-dev#31e327.patch4.51 KBorlando.thoeny

Comments

orlando.thoeny created an issue. See original summary.

orlando.thoeny’s picture

orlando.thoeny
Location Switzerland 🇨🇭
commented
StatusFileSize
new make_comment_admin_overview_query_alterable-2990248-1-8.6.x-dev#31e327.patch4.51 KB
new make_comment_admin_overview_query_alterable-2990248-1-8.5.6.patch4.51 KB

I created a patch for the current 8.6.x dev branch and the 8.5.6 release.

markdorison’s picture

markdorison
he/him
commented
Version: 8.6.x-dev » 8.8.x-dev
Issue tags: +Needs tests

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

nemanja’s picture

nemanja commented
StatusFileSize
new make_comment_admin_overview_query_alterable-2990248-2.patch3.21 KB

Patch for 9.2 core version

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
StatusFileSize
new 2990248-9.patch4.53 KB
new reroll_diff_2990248_2-9.txt2.6 KB

The rerolled patch in #8 had a file missing (+ b/core/modules/comment/src/Event/CommentAdminOverviewQueryEvent.php).

Rerolled tha patch in #2 again and changed the deprecated class usage from use Symfony\Component\EventDispatcher\Event; to use Drupal\Component\EventDispatcher\Event; .

Thank you!

Status: Needs review » Needs work

The last submitted patch, 9: 2990248-9.patch, failed testing. View results

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.