Closed (fixed)
Project:
Drupal core
Version:
8.7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Aug 2018 at 06:18 UTC
Updated:
23 Aug 2018 at 10:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
msankhala commentedAlso, it is showing Enf of defgroup on document page which it should not.
Comment #3
jwlockhart commentedI am working on this issue at #uoecontributiondayAug2018
I have created a patch, but wanted to run it past first before uploading the file, just to check it was along the correct lines.
@msankhala Just seen comment, I have removed end defgroup reference, happy to receive feedback and look at taking this forward.
Comment #4
jwlockhart commentedComment #5
msankhala commentedI think removing the end of defgroup is not the correct solution. See @defgroup documentation in api documentation standard. Looks like issue is with formatting or with the quotes within @defgroup.
Comment #6
joachim commentedYup, see https://www.drupal.org/docs/develop/coding-standards/api-documentation-a...
Comment #7
msankhala commented@jwlockhart You can submit the patch. Yes, you are right if @defgroup is defined as per syntax example 1 mentioned in documentation then
End of "group_name"is not necessary.Syntax example 1 for defining a group:
Comment #8
msankhala commented@joachim Sorry You haven't submitted the patch so I am submitting the one. Also changing branch to 8.7.x.
Comment #9
joachim commentedThanks! Looks good to me.
Comment #10
alexpottUpdating issue credit.
Comment #11
alexpottCommitted and pushed 1781eeafc3 to 8.7.x and cf7c5cd81e to 8.6.x. Thanks!
Backported to 8.6.x since it is a docs fix.