Problem/Motivation

I have found several typos in the views module - three of them in comments, and one in a variable name ($filter_hander in ExposedFormPluginBase.php).

Proposed resolution

The included patch should fix all the typos I found.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 2989609-4.patch967 bytessivaji_ganesh_jojodae
#2 views_typos-2989609-2.diff2.68 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented

JKerschner created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
StatusFileSize
new views_typos-2989609-2.diff2.68 KB
Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: views_typos-2989609-2.diff, failed testing. View results

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Title: Fix typos in Views module » $filter_hander typo in Views ExposedFormPluginBase.php
Version: 8.6.x-dev » 8.9.x-dev
Status: Needs work » Needs review
Issue tags: +Novice
StatusFileSize
new 2989609-4.patch967 bytes

$filter_hander renamed to $filter_handler.

Other issues in the previous patch seem already fixed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Simple fix, looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 8ef710c and pushed to 9.0.x, 8.9.x and 8.8.x. Thanks!

Backported to 8.8.x as this is a variable rename.

  • alexpott committed 8ef710c on 9.0.x 
    Issue #2989609 by CeraRose, Sivaji: $filter_hander typo in Views...

  • alexpott committed 26bf43a on 8.9.x 
    Issue #2989609 by CeraRose, Sivaji: $filter_hander typo in Views...

  • alexpott committed b22b0ab on 8.8.x 
    Issue #2989609 by CeraRose, Sivaji: $filter_hander typo in Views...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.