Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
31 Jul 2018 at 13:43 UTC
Updated:
11 Oct 2018 at 08:29 UTC
Jump to comment: Most recent
Comments
Comment #2
albacross commentedHi lexsoft,
Here's the report of automated testing with issues, please fix them
https://pareview.sh/pareview/https-git.drupal.org-project-ckeditor_boots...
Comment #3
avpadernoComment #4
lexsoft00 commentedHi @albacross
Have you seen the automated testing? There are no errors!
Had you the decency to actually test the module?
Comment #5
lexsoft00 commentedComment #6
avpadernoWhile PAReview doesn't report errors, reviewers are requested to check if the applicant knows Drupal coding standards. Namespaced dependencies are reccommended.
That is not the correct documentation comment for a method that has been defined on a parent class.
Comment #7
lexsoft00 commentedHi @kiamlaluno,
Thank you for taking the time to point out the mistake done.
I know you are really busy with a lot of application and we are not making your job easy.
I've made the changes, please review and let me know if there is more to be done.
Thanks,
Alex
Comment #8
lexsoft00 commentedComment #9
avpadernoTo the reviewers: Please change the priority to Normal after reviewing the code.
Comment #10
avpadernoPAreview just reports the dependencies from other modules. I will make a manual review later today.
Comment #11
avpadernoI apologize: I will make a manual review this evening.
Comment #12
avpadernoES6 code should go in .es6.js files that are then compiled to ES5 files before committing the code in the repository. (It's what Drupal core does too.)
I will approve the application tomorrow.
Comment #13
lexsoft00 commentedHi kiamlaluno,
I will include this in the next release.
Thank you
Comment #14
avpadernoThank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.