This is just another small module introducing the Bootstrap Grid to CKEditor.

  1. Allows to easy add 2, 3 bootstrap columns with good visual display
  2. Nice dropdown menu from CKEditor

Project link

https://www.drupal.org/project/ckeditor_bootstrap_grid

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/ckeditor_bootstrap_grid.git

Comments

lexsoft created an issue. See original summary.

albacross’s picture

Hi lexsoft,
Here's the report of automated testing with issues, please fix them
https://pareview.sh/pareview/https-git.drupal.org-project-ckeditor_boots...

avpaderno’s picture

Issue summary: View changes
Status: Needs review » Needs work
lexsoft00’s picture

Hi @albacross
Have you seen the automated testing? There are no errors!
Had you the decency to actually test the module?

lexsoft00’s picture

Status: Needs work » Needs review
avpaderno’s picture

Status: Needs review » Needs work

While PAReview doesn't report errors, reviewers are requested to check if the applicant knows Drupal coding standards. Namespaced dependencies are reccommended.

 /**
   * Implements \Drupal\ckeditor\Plugin\CKEditorPluginInterface::getFile().
   */
  public function getFile() {
    return drupal_get_path('module', 'ckeditor_bootstrap_grid') . '/js/plugins/widgettemplatemenu/plugin.js';
  }

That is not the correct documentation comment for a method that has been defined on a parent class.

lexsoft00’s picture

Hi @kiamlaluno,

Thank you for taking the time to point out the mistake done.
I know you are really busy with a lot of application and we are not making your job easy.
I've made the changes, please review and let me know if there is more to be done.

Thanks,
Alex

lexsoft00’s picture

Status: Needs work » Needs review
avpaderno’s picture

Priority: Normal » Critical

To the reviewers: Please change the priority to Normal after reviewing the code.

avpaderno’s picture

Assigned: Unassigned » avpaderno

PAreview just reports the dependencies from other modules. I will make a manual review later today.

avpaderno’s picture

I apologize: I will make a manual review this evening.

avpaderno’s picture

Priority: Critical » Normal
Status: Needs review » Reviewed & tested by the community

ES6 code should go in .es6.js files that are then compiled to ES5 files before committing the code in the repository. (It's what Drupal core does too.)

I will approve the application tomorrow.

lexsoft00’s picture

Hi kiamlaluno,

I will include this in the next release.

Thank you

avpaderno’s picture

Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.