While evaluating this module I noticed that on the Extend page, the project name is in lower case and should be in title case to be consistent with the rest of the project names on the page.

"Capitalize the name of the module, because module names are proper nouns."

https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...

Patch to follow, thanks!

CommentFileSizeAuthor
#4 pagemenureorder.png23.84 KBlegaudinier
#2 page_menu_reorder-capitalize-name-2988646-2.patch1.2 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Status: Active » Needs review
StatusFileSize
new page_menu_reorder-capitalize-name-2988646-2.patch1.2 KB

I uploaded a patch that Capitalizes the name of the project in the .info and .module files.

Thanks!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
legaudinier’s picture

legaudinier commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new pagemenureorder.png23.84 KB

The patch applies cleanly with simplytest.me and the module name capitalization has been fixed. See the attached screenshot. Marking as RTBC. Thanks!

calonghini’s picture

calonghini commented

Hi volkswagenchick and legaudinier,

Thanks for checking this for us. We implemented the changes and the code is updated.

Thanks again!

calonghini’s picture

calonghini commented
Status: Reviewed & tested by the community » Fixed
calonghini’s picture

calonghini commented
Status: Fixed » Closed (fixed)