Some context properties are empty when generating a letsencrypt certificate

Inside generate_certificates in Provision_Service_Certificate_LetsEncrypt some of the properties are accessed using d()->server but they are empty. The properties in question are letsencrypt_script_path, letsencrypt_config_path and letsencrypt_ca. This caused two problems:

• The certificate generation fails because it tries to run /script instead of /var/aegir/config/letsencrypt/script because d()->server->letsencrypt_script_path is empty.
• After fixing the script path, certificates were generated using the staging ca, even when set to use production because d()->server->letsencrypt_ca is empty (both in the server alias file and the UI the CA was right).

I see that everywhere else in the code those properties are accessed directly in the service instance using $this->server instead of d()->server.

Old description

I can't generate certificates with letsencrypt. I have enabled the LetsEncrypt certificate service for the webserver and everything worked OK. I then enabled encryption for a site hosted in that webserver and the verify task fails.

The certificate generation fails because it tries to run /script instead of /var/aegir/config/letsencrypt/script because d()->server->letsencrypt_script_path is empty. In other parts of the submodules/letsencrypt/drush/Provision/Service/Certificate/LetsEncrypt.php file we are using $this->server->letsencrypt_script_path, would it be OK to change that?