The elements of the RemoteImageWidget appear on the same level as all the other fields of the entity form, making it difficult to differentiate them.

It would be better if the field is rendered in a similar way to the link field, which uses a fieldset as container.

CommentFileSizeAuthor
#3 interdiff-2987323-2-3.txt534 bytestucho
#3 remote_image-improve_widget-2987323-3.patch1.05 KBtucho
#2 remote_image-improve_widget-2987323-2.patch800 bytestucho

Comments

tucho created an issue. See original summary.

tucho’s picture

tucho
Primary language Spanish
Location Buenos Aires
commented
Status: Active » Needs review
StatusFileSize
new remote_image-improve_widget-2987323-2.patch800 bytes

The LinkWidget uses a fieldset when the link's title is not disabled:

       if ($this->getFieldSetting('title') == DRUPAL_DISABLED) {
         $element['uri']['#title'] = $element['#title'];
         ...
       }
       // Otherwise wrap everything in a details element.
       else {
         $element += [
           '#type' => 'fieldset',
         ];
       }

The RemoteImageItem disables the link title, so the dieldset wrapper is not used.

I uploaded a patch that restores the logic of the LinkWidget, using a fieldset as container for the widget fields.

tucho’s picture

tucho
Primary language Spanish
Location Buenos Aires
commented
StatusFileSize
new remote_image-improve_widget-2987323-3.patch1.05 KB
new interdiff-2987323-2-3.txt534 bytes

I uploaded a new patch that also delete two widget settings: placeholder_width and placeholder_height, which are not used anywhere.

There is also a trivial interdiff.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Reviewed & tested by the community

The form widget looks much better after these changes. Thanks

  • gaurav.kapoor committed 9495fce on 8.x-1.x authored by tucho 
    Issue #2987323 by tucho, gaurav.kapoor: Improve the presentation of the...
gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.