While evaluating this module I noticed that on the Module page, the project name is in lower case and should be capitalized to be consistent with the rest of the project names on the page.
"Capitalize the name of the module, because module names are proper nouns."
https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...
Patch to follow, thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | external-link-change-d8-capitalize-name-2986364-10.patch | 352 bytes | darrylri |
| #7 | only capitalized .png | 85.32 KB | volkswagenchick |
| #4 | Before_patch_External link change.png | 19.9 KB | akash.addweb |
| #4 | After_patch_External link change.png | 20.54 KB | akash.addweb |
| #3 | external_link_change-d7-capitalize-name-2986364-3.patch | 327 bytes | volkswagenchick |
Comments
Comment #2
volkswagenchickupdating to read Drupal7 branch
Comment #3
volkswagenchickI uploaded a patch that capitalizes the name of the module in the .info file so it is consistent with the rest of the projects listed on the Module page. Thanks!
Comment #4
akash.addweb commented@volkswagenchick, Thanks for providing patch, but I think module name is still not capitalized, Please change "
External Link change" to "External Link Change", Also this should be changed at all the places that you're covered. PFA
Comment #5
volkswagenchickI understand your thoughts, but in drupal7 most of the modules are not in complete title case, just capitalized. I am trying to be consistent with core. Thanks
Does anyone else want to weigh in?
Comment #6
volkswagenchickComment #7
volkswagenchickscreenshot attached.
Comment #8
dani3lr0se commentedI concur with @volkswagenchick. In Drupal 7 only the first word is consistently capitalized, as opposed to Drupal 8 where every word is capitalized. It's best to try and keep everything consistent per Drupal standards. Core is a good example to reference for consistency. I'm going to mark this as RTBC as I've also tested and reviewed. Looks good and patch applies cleanly. Thanks for the patch @volkswagenchick! :)
Comment #9
darrylriI notice that the D8 module also has capitalization problems, all lower case as well.
Comment #10
darrylriComment #11
volkswagenchickThe last patch for the D8 branch failed testing. Since it is a D8 issue and the original issue for this was D7 and the patch in #7 was marked RTBC, I'm going to mark this as RTCB and open a new issue so this one is not blocked.
Thanks everyone for the work here.
Comment #12
volkswagenchickComment #14
guptahemant commentedThanks for the contribution, marking the issue as fixed.