Problem/Motivation
The listings:
- Top 'access denied' errors.
- Top 'page not found' errors.
- Top search phrases.
Provided by dblog are using some database specific logic to return information. I'm not even sure how much this pages are being used by Drupal users anyway.
I would like to propose to replace those lists by views only versions and delete the dblog specific code from the module. Doing this reduced dblog complexity and helps to simplify #2458191: Provide a storage backend for dblog module.
Proposed resolution
- Replace Top access denied errors, Top page not found and Top search phrases with a view.
- Delete the code relevant to this functionality from dblog.
- If the deletion is not possible due backward compatibility polices, at least deprecate those mothods from the module.
Remaining tasks
- Discuss if this is a valid request.
- Make a patch.
User interface changes
None if the views module is enabled. The user interface provided by views is identical to the created by dblog.
API changes
Deprecation or deletion of DbLogController::topLogMessages().
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | views.view_.top_404_pages.yml | 7.7 KB | poker10 |
Comments
Comment #2
dagmarComment #3
dagmarComment #9
dagmarI found way to deal with this feature here #2401463: Make dblog entities.
Comment #10
ressaThanks @dagmar for all your work on the other issue, I very much appreciate it!
I wonder if this issue should be re-opened and added as a child issue to #2401463: Make dblog entities? Since it does not look to me like new Views pages are added, or maybe I just missed them?
I personally would love it, if the "Page not found" page could be expanded with a time-filter, so you can limit to "Last day" or "Last seven day" and maybe a text filter as well?
Comment #11
poker10 commentedI agree with @ressa and reopening this feature request.
There is another issue to add additional column to the listing (#3291914: Include most recent date in page not found and access denied reports), but I am not sure we should be doing that, given it is a static hardcoded table, without any pager or other possible customization options for site admins. Instead we should consider creating these pages as views, which seems to be a correct approach - then, almost any customization will be possible, even without additional core changes.
It does not seems to be hard to create a similarly working view - for an example view for "top 404 pages" see the config I attached (it is an export of the view we have used when replaced the old pages). It is not fully complete to be committed as is, but it can serve as some starting point for this issue.
Thanks!
Comment #12
ressaSounds great, thanks for taking a look at this and even including a patch poker10. Fingers crossed it can eventually be expanded with features, such as a time-filter or similar method, to more easily see the latest 404's.