Problem/Motivation

The listings:

  • Top 'access denied' errors.
  • Top 'page not found' errors.
  • Top search phrases.

Provided by dblog are using some database specific logic to return information. I'm not even sure how much this pages are being used by Drupal users anyway.

I would like to propose to replace those lists by views only versions and delete the dblog specific code from the module. Doing this reduced dblog complexity and helps to simplify #2458191: Provide a storage backend for dblog module.

Proposed resolution

  • Replace Top access denied errors, Top page not found and Top search phrases with a view.
  • Delete the code relevant to this functionality from dblog.
  • If the deletion is not possible due backward compatibility polices, at least deprecate those mothods from the module.

Remaining tasks

  • Discuss if this is a valid request.
  • Make a patch.

User interface changes

None if the views module is enabled. The user interface provided by views is identical to the created by dblog.

API changes

Deprecation or deletion of DbLogController::topLogMessages().

Data model changes

CommentFileSizeAuthor
#11 views.view_.top_404_pages.yml7.7 KBpoker10

Comments

dagmar created an issue. See original summary.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Issue summary: View changes
dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Issue summary: View changes

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Active » Closed (won't fix)

I found way to deal with this feature here #2401463: Make dblog entities.

ressa’s picture

ressa
he/him
commented

Thanks @dagmar for all your work on the other issue, I very much appreciate it!

I wonder if this issue should be re-opened and added as a child issue to #2401463: Make dblog entities? Since it does not look to me like new Views pages are added, or maybe I just missed them?

I personally would love it, if the "Page not found" page could be expanded with a time-filter, so you can limit to "Last day" or "Last seven day" and maybe a text filter as well?

poker10’s picture

poker10 commented
Title: Proposal to make "Top 'page not found' errors." and related listings only available via views. Remove them from dblog » Convert "Top 'access denied' errors.", "Top 'page not found' errors" and Top search phrases to views
Version: 9.3.x-dev » 11.x-dev
Status: Closed (won't fix) » Needs work
Related issues: +#3291914: Include most recent date in page not found and access denied reports
StatusFileSize
new views.view_.top_404_pages.yml7.7 KB

I agree with @ressa and reopening this feature request.

There is another issue to add additional column to the listing (#3291914: Include most recent date in page not found and access denied reports), but I am not sure we should be doing that, given it is a static hardcoded table, without any pager or other possible customization options for site admins. Instead we should consider creating these pages as views, which seems to be a correct approach - then, almost any customization will be possible, even without additional core changes.

It does not seems to be hard to create a similarly working view - for an example view for "top 404 pages" see the config I attached (it is an export of the view we have used when replaced the old pages). It is not fully complete to be committed as is, but it can serve as some starting point for this issue.

Thanks!

ressa’s picture

ressa
he/him
commented

Sounds great, thanks for taking a look at this and even including a patch poker10. Fingers crossed it can eventually be expanded with features, such as a time-filter or similar method, to more easily see the latest 404's.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.