This module extends original Drupal 8 account settings page with the ability to turn ON/OFF all standard mails. By default Drupal 8 provides no option to disable welcome emails, account cancellation confirmation or password reset.

This can be useful when you don't want to send those emails, or you are sending them through some external services like mandrill or just for development purposes, etc.

Project link

https://www.drupal.org/project/mail_control

Git instructions

git clone --branch 8.x-1.0 https://git.drupal.org/project/mail_control.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-mail_control.git

Comments

soaratul created an issue. See original summary.

soaratul’s picture

soaratul commented
Status: Active » Needs review

Changing it's status to Needs review..

ManishJ.’s picture

ManishJ. commented

Hello soaratul,

Please run automated review and check the errors.

Here is the report. https://pareview.sh/pareview/https-git.drupal.org-project-mail_control.git

Thanks

sagar_cis’s picture

sagar_cis commented
Issue summary: View changes
sagar_cis’s picture

sagar_cis commented
Issue summary: View changes
soaratul’s picture

soaratul commented

Thank you manish_cis,

I've fixed all the errors and warning suggested by pareview.sh.

sagar_cis’s picture

sagar_cis commented
Status: Needs review » Needs work

Hello @soaratul

I install this module and check "Notify user when account is created by admin", but when i create a user from admin account it did not set checkbox of "Notify user of new account" by default. it should set it by default check, other wise there is no difference in functionality. Drupal Already Provide us a checkbox to control notification mail.

Thanks

soaratul’s picture

soaratul commented

@vishal_cis the intent of this module is to start/stop mail notification triggered from drupal.

Instead of sending it from drupal, sometime developer/product owner wants to send such mail from other sources like mailchimp/oracle responsys.

In that case this module be helpful.

Checkbox on /admin/people/create page is already configurable that don't needs to be change.

Your thought please.

soaratul’s picture

soaratul commented

My mistake, posted twice, deleting here.

soaratul’s picture

soaratul commented
Status: Needs work » Needs review
manish.upadhyay’s picture

manish.upadhyay commented
Status: Needs review » Reviewed & tested by the community

Hi,

I have installed this module and it is working fine also i can't find any major issue with it.

Thanks,

manish.upadhyay’s picture

manish.upadhyay commented
manish.upadhyay’s picture

manish.upadhyay commented

Just FYI please add some description on the module page as it is required for the user to get some insight of the module.

Thanks,

soaratul’s picture

soaratul commented

Thanks @manish.upadhyay for your time, sure I will add more information in description.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs review

Reviewing a project for this application requires more than trying the module/theme.

We are mainly interested in checking if the OP understands how to write secure code, follow Drupal coding standards, and follow the error/bug reports opened for the code the OP writes.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Major

To the reviewers: Please set the priority to Normal after reviewing the project.

rajeevgole’s picture

rajeevgole
He/Him
Primary language English
commented
Priority: Major » Normal
Status: Needs review » Needs work

This look similar to Mailcontrol. Please check to avoid duplicates.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Critical
Status: Needs work » Needs review

Duplication of existing modules is not an application stopper. It would be fine if the applicant would make a comparison with the existing modules.

To the reviewers: Please change back the priority to Normal after doing a review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Critical » Normal
Status: Needs review » Needs work

On Drupal.org, 8.x-1.0-alpha1 is not a correct branch name. It can be a tag name, but not a branch name. See also Release naming convention, which describes the correct names to give to branches and tags.

saesa’s picture

saesa commented
Issue summary: View changes
soaratul’s picture

soaratul commented

@rajeevgole thank you for your input, I have merged this module to existing Mailcontrol.

@kiamlaluno your suggestions are really helpful and it's +1 to my existing knowledge.

Guys, Can we please close this issue as I have added this in existing Mailcontrol module?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

Keep in mind that you still don't have the vetted role. I am closing this application as requested.