Capitalize the name of the module, because module names are proper nouns.

CommentFileSizeAuthor
#5 contact_permissions-d8-capitalize-name-2985665-5.patch342 bytesvolkswagenchick
#2 contact_permissions-d8-capitalize-name-2985665-2.patch422 bytesdarrylri

Comments

darrylri created an issue. See original summary.

darrylri’s picture

darrylri
Primary language English
Location Santa Cruz, California
commented
StatusFileSize
new contact_permissions-d8-capitalize-name-2985665-2.patch422 bytes

Capitalize module name in the .info.yml file.

darrylri’s picture

darrylri
Primary language English
Location Santa Cruz, California
commented
Assigned: darrylri » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: contact_permissions-d8-capitalize-name-2985665-2.patch, failed testing. View results

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new contact_permissions-d8-capitalize-name-2985665-5.patch342 bytes

The last patch failed testing - I uploaded a new patch that capitalizes the name of the module

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs work » Needs review

The patch in Comment 5 applies via simplytest.me, marking as needs review

manuel garcia’s picture

manuel garcia commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch, yup, should be capitalized :)

  • Manuel Garcia committed 7df5288 on 8.x-1.x 
    Issue #2985665 by darrylri, volkswagenchick: Capitalize the name of the...
manuel garcia’s picture

manuel garcia commented
Status: Reviewed & tested by the community » Fixed
manuel garcia’s picture

manuel garcia commented

I've also capitalized the name of the module on the project page for consistency.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.