Optimize EntityOperations::entityView()

Makes sense, LGTM!

1. +++ b/core/modules/content_moderation/src/EntityOperations.php
   @@ -278,15 +279,24 @@ public function entityView(array &$build, EntityInterface $entity, EntityViewDis
   +    if (($entity->isDefaultRevision() || $entity->wasDefaultRevision())) {
   

   Unnecessary () - however I suggest a re-implementation below that makes them necessary again.

2. +++ b/core/modules/content_moderation/src/EntityOperations.php
   @@ -278,15 +279,24 @@ public function entityView(array &$build, EntityInterface $entity, EntityViewDis
   +      // If the entity implements EntityPublishedInterface directly, check that
   +      // first, otherwise fall back to check through the workflow state.
   +      if ($entity instanceof EntityPublishedInterface) {
   +        if ($entity->isPublished()) {
   +          return;
   +        }
   +      }
   +      elseif ($moderation_state = $entity->get('moderation_state')->value) {
   +        $workflow = $this->moderationInfo->getWorkflowForEntity($entity);
   +        if ($workflow->getTypePlugin()->getState($moderation_state)->isPublishedState()) {
   +          return;
   +        }
   +      }
   

   I think this might be simpler if moved to a helper method. For example:

    /**
      * Act on entities being assembled before rendering.
      *
      * @see hook_entity_view()
      * @see EntityFieldManagerInterface::getExtraFields()
      */
     public function entityView(array &$build, EntityInterface $entity, EntityViewDisplayInterface $display, $view_mode) {
       /** @var \Drupal\Core\Entity\ContentEntityInterface $entity */
       if (!$this->moderationInfo->isModeratedEntity($entity)) {
         return;
       }
       if (isset($entity->in_preview) && $entity->in_preview) {
         return;
       }
       // If the component is not defined for this display, we have nothing to do.
       if (!$display->getComponent('content_moderation_control')) {
         return;
       }
       // The moderation form should be displayed only when viewing the latest
       // (translation-affecting) revision, unless it was created as published
       // default revision.
       if (($entity->isDefaultRevision() || $entity->wasDefaultRevision()) && $this->isPublished($entity)) {
         return;
       }
       if (!$entity->isLatestRevision() && !$entity->isLatestTranslationAffectedRevision()) {
         return;
       }
   
       $build['content_moderation_control'] = $this->formBuilder->getForm(EntityModerationForm::class, $entity);
     }
   
     /**
      * Checks if the entity is published.
      * 
      * This method is optimised to not have to unnecessarily load the moderation
      * state and workflow if it is not required.
      *
      * @param $entity
      *
      * @return bool
      */
     protected function isPublished($entity) {
       // If the entity implements EntityPublishedInterface directly, check that
       // first, otherwise fall back to check through the workflow state.
       if ($entity instanceof EntityPublishedInterface) {
         return $entity->isPublished();
       }
       if ($moderation_state = $entity->get('moderation_state')->value) {
         $workflow = $this->moderationInfo->getWorkflowForEntity($entity);
         return $workflow->getTypePlugin()->getState($moderation_state)->isPublishedState();
       }
       return FALSE;
     }
   

Looks great to me! If someone could fix this at some point, it would be even better:

+++ b/core/modules/content_moderation/src/EntityOperations.php
@@ -278,17 +280,39 @@ public function entityView(array &$build, EntityInterface $entity, EntityViewDis
+   * This method is optimised to not have to unnecessarily load the moderation

"optimised" -> "optimized" :)

Fixed #6 on commit. Committed e9dd745 and pushed to 8.6.x. Thanks!