Problem/Motivation
Spun off from #2878119: Whether queued or not, update the media thumbnail and metadata before beginning the entity save database transaction.
Since it's a method of MediaSourceInterface, I guess that makes sense. But I think this could potentially backfire on us later, in circumstances where the === comparison we're doing is not going to be a sufficient determinant of whether the value has changed. For example, if the source field value is a formatted text field, then changing the format could constitute a significant enough change that an update is required, even if the primary value has not changed.
Having said that...maybe that's an edge case and I'm being overly paranoid. And even if someone does encounter it, it is workaround-able by ninjas. So for now, let's stick with what we have in this patch, and open a follow-up to talk more about whether we need a more robust way to determine if a change has occurred.
Comments