See #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)

CommentFileSizeAuthor
#2 2982738-2.patch1.26 KBApacheEx

Comments

ApacheEx created an issue. See original summary.

ApacheEx’s picture

ApacheEx commented
Status: Active » Needs review
StatusFileSize
new 2982738-2.patch1.26 KB

Here is patch.

ApacheEx’s picture

ApacheEx commented
Parent issue: #2863626: Convert web tests to browser tests for image module » #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)
Related issues: +#2863626: Convert web tests to browser tests for image module
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#1252606: Add crop anchor option to Scale and Crop image effect

Yeah, #1252606: Add crop anchor option to Scale and Crop image effect mistakingly added a WTB test instead of a BTB one for the update path. Good catch @ApacheEx!

  • xjm committed f5f9204 on 8.6.x 
    Issue #2982738 by ApacheEx: Convert Drupal\image\Tests\Update\...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.6.x. Thanks!

An issue like this would be backported to 8.5.x to reduce merge conflicts between branches, but the test does not exist there as such. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.