Problem/Motivation

Versions of our eslint packages are out of date and should be updated.

Proposed resolution

Update versions of our coding standards dependencies.

CommentFileSizeAuthor
#2 2982345-2.patch41.1 KBApacheEx

Comments

ApacheEx created an issue. See original summary.

ApacheEx’s picture

ApacheEx commented
Status: Active » Needs review
StatusFileSize
new 2982345-2.patch41.1 KB

Here is patch. Upgrading eslint packages introduce new lint issues - them should be fixed in meta issue: #2912962: Step 1 JS codestyle: [meta] Fix JS coding standards in core

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
Status: Needs review » Reviewed & tested by the community

🎉

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue tags: +Needs followup

We should open follow-up issues for the new turned off eslint rules.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented

Done, and attached to the parent, #2912962: Step 1 JS codestyle: [meta] Fix JS coding standards in core

  • lauriii committed 95a478f on 8.6.x 
    Issue #2982345 by ApacheEx, drpal: Update eslint packages to most recent...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -JavaScript, -Needs followup +javascript aggregator

Committed 2c99ba5 and pushed to 8.6.x. Thanks!

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue tags: -javascript aggregator +JavaScript

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

Wow. This was so close to being a bad thing: https://eslint.org/blog/2018/07/postmortem-for-malicious-package-publishes