Problem/Motivation

See https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

public function getStorage($entity_type);

getStorage() only has 1 parameter, but it's being called with 2.

src/Plugin/ImporterBase.php L113

$entity = $this->entityTypeManager->getStorage($this->configuration['entity_type'], $this->configuration['entity_type_bundle'])->create($content);

Proposed resolution

Remove the second parameter. Bundle is already supplied by the $content variable and is respected by the create() method.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 2981456-3.patch770 bytesmahtab_alam
#2 csv_importer-missing_bundle_param-2981456-2.patch616 bytespingers

Comments

pingers created an issue. See original summary.

pingers’s picture

pingers commented
Assigned: pingers » Unassigned
Status: Active » Needs review
StatusFileSize
new csv_importer-missing_bundle_param-2981456-2.patch616 bytes

Here's a patch.

mahtab_alam’s picture

mahtab_alam commented
StatusFileSize
new 2981456-3.patch770 bytes
pingers’s picture

pingers commented

I'm sorry, why do we need a patch with a commented out line of code? This is why we use git.

mikejw’s picture

mikejw commented

patch in #2 looks good.

lashabp’s picture

lashabp commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.