The 'Translation Operations' views field provides buttons for translating content - an Add button if no translation exists in the target language, or an Edit button if one does.

Am I correct in assuming that the Edit link should direct to the translation in the target language, not the source language (row language)? If so, patch attached.

CommentFileSizeAuthor
#7 translation_views-edit_button_target_language-7.patch10.26 KBvalentine94
#6 translation_views-edit_button_target_language-6.patch17.26 KBvalentine94
#5 translation_views-edit_button_target_language-5.patch3.98 KBvalentine94
#4 translation_views-edit_button_target_language-3.patch3.06 KBmatsbla
#3 translation_views-edit_button_target_language-2.patch2.93 KBmatsbla
translation_views-edit_button_target_language-1.patch1.88 KBbgilhome

Comments

bgilhome created an issue. See original summary.

matsbla’s picture

matsbla commented

Thanks for reporting and submit a patch! You're right, I can confirm the issue.
Will fix this, but want to fix 2 other issues at the same time concerning the translation operation links, to see that it all works good together;
#2957229: Integrate module with Content Moderation
#2956500: Build translation operations links using translation permissions

matsbla’s picture

matsbla commented
StatusFileSize
new translation_views-edit_button_target_language-2.patch2.93 KB

I think there is a similar issue with the check to see if current language is the default language. Now it checks if default language is the row language (and if so it hides the delete link from the operation menu).

matsbla’s picture

matsbla commented
StatusFileSize
new translation_views-edit_button_target_language-3.patch3.06 KB
valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
StatusFileSize
new translation_views-edit_button_target_language-5.patch3.98 KB

Patch re-roll due to the latest commit changes

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
StatusFileSize
new translation_views-edit_button_target_language-6.patch17.26 KB

Add some tests, a bit rework old tests, remove redundant test view

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
StatusFileSize
new translation_views-edit_button_target_language-7.patch10.26 KB

Rework patch a bit

  • matsbla committed ba2245c on 8.x-1.x authored by Valentine94 
    Issue #2981106 by Valentine94, matsbla, bgilhome: Edit button should...
matsbla’s picture

matsbla commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.