Problem/Motivation

The tests are currently not running due to a syntax error in \Drupal\Tests\term_split\Kernel\TermSplitterTest:

PHP Parse error: syntax error, unexpected ':', expecting ';' or '{' in /var/www/html/modules/contrib/term_split/tests/src/Kernel/TermSplitTestBase.php on line 94

See https://www.drupal.org/pift-ci-job/833435

Proposed resolution

Fix the syntax error to enable automated testing by Drupal infrastructure

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#12 2980691-12.patch2.46 KBidebr
#12 interdiff-10-12.txt616 bytesidebr
#10 2980691-10.patch1.86 KBlegolasbo
#9 term_split-syntax_error-2980691-9.patch1.52 KBlegolasbo
#7 term_split-syntax_error-2980691-7.patch1.88 KBlegolasbo
#4 term_split-syntax_error-2980691-4.patch2.08 KBidebr
#4 interdiff-2-4.txt975 bytesidebr
#2 term_split-syntax_error-2980691-2.patch1.02 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new term_split-syntax_error-2980691-2.patch1.02 KB

Attached patch fixes the syntax error, so the Drupal infrastructure can do automated testing.

Status: Needs review » Needs work

The last submitted patch, 2: term_split-syntax_error-2980691-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-4.txt975 bytes
new term_split-syntax_error-2980691-4.patch2.08 KB

Added a @group annotation for the Drupal testbot.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Will commit once testbot thinks this is ok ;)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: term_split-syntax_error-2980691-4.patch, failed testing. View results

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs work » Needs review
StatusFileSize
new term_split-syntax_error-2980691-7.patch1.88 KB

Fixed another error.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented

The remaining test failure is caused by a classname mismatch in hook_event_dispatcher for which I've created #3052240: Classname mismatch causes tests failures.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
StatusFileSize
new term_split-syntax_error-2980691-9.patch1.52 KB

Rerolled the patch

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
StatusFileSize
new 2980691-10.patch1.86 KB

Let's try again.

Status: Needs review » Needs work

The last submitted patch, 10: 2980691-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-10-12.txt616 bytes
new 2980691-12.patch2.46 KB

Removed the unused Drupal\Console\Command\Shared\TranslationTrait

  • legolasbo committed f38ef18 on 8.x-1.x authored by idebr 
    Issue #2980691 by idebr, legolasbo: TermSplitterTest has a syntax error...
legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs review » Fixed

Committed and pushed to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.