Hi,
I have used this module many times for Drupal 7 and loved it.
Now trying to use for D8 but I got several warnings about undefined variables of #type and #title.
I also notices that it doesn't implement any way to set an asterisk for required fields.
I have attached a patch that I think is the right way to go about fixing both of these issues, but this is my first patch for a contributed module so I have no idea if I have done this right or not.
I have also attached patches for the two standard templates that come with the module to implement the asterisk.
Thanks,
James
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2980245-4.patch | 3.43 KB | yogeshmpawar |
| required_field_and_unset_variables.patch | 1.92 KB | james hawthorn-byng | |
| required_fields_into_standard_templates.patch | 1.64 KB | james hawthorn-byng |
Comments
Comment #2
dmkelner commentedThis is a major user experience issue. I'm a UX person, not a coder. Can this please get a patch committed to a stable release? I appreciate the work above, but it isn't rolled into a usable patch.
Comment #3
yogeshmpawarComment #4
yogeshmpawarThanks @James Byng, for pointing out this issue. As this your's first patch to any contributed module.
I think you should combine both the above patches in one patch.
Also I have find out one issue that whenever you are creating any patch from module you should compulsory use the latest DEV version of the module ie. 8.x-1.x so that your patch will apply with no error.
I found that your first patch is failed to apply on 8.x-1.x branch, so for this reason I am creating a new patch with all your changes included in it.
Comment #6
yogeshmpawarThanks once again @James Byng & @dmkelner for working on this issue.
@james Byng - Continue your good work in the future. This is really appreciating that developers new to contribution done this level of work.
I have manually test above patch, so Committed & Pushed to 8.x-1.x branch.