Problem/Motivation

The total votes is displayed as two separate strings. This makes it harder for translators to get the context required for a good translation.

Proposed resolution

Use a variable placeholder when rendering 'Total votes' in the Poll results.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#11 2979858-10.patch8.15 KBlendude
#8 poll-variable_placeholder-2979858-8.patch9.96 KBidebr
#8 interdiff-6-8.txt6.55 KBidebr
#6 interdiff-4-6.txt2.4 KBidebr
#6 poll-variable_placeholder-2979858-6.patch3.18 KBidebr
#4 poll-variable_placeholder-2979858-4.patch739 bytesidebr
#4 interdiff-2-4.txt396 bytesidebr
#2 poll-variable_placeholder-2979858-2.patch748 bytesidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new poll-variable_placeholder-2979858-2.patch748 bytes

Attached patch implements a variable placeholder when rendering 'Total votes' in the Poll results, so translators get the context required for a good translation.

Status: Needs review » Needs work

The last submitted patch, 2: poll-variable_placeholder-2979858-2.patch, failed testing. View results

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-4.txt396 bytes
new poll-variable_placeholder-2979858-4.patch739 bytes

Leaving the div-wrapper in this time.

Status: Needs review » Needs work

The last submitted patch, 4: poll-variable_placeholder-2979858-4.patch, failed testing. View results

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new poll-variable_placeholder-2979858-6.patch3.18 KB
new interdiff-4-6.txt2.4 KB

Removed the double spaces from the test

Status: Needs review » Needs work

The last submitted patch, 6: poll-variable_placeholder-2979858-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-6-8.txt6.55 KB
new poll-variable_placeholder-2979858-8.patch9.96 KB

Removed more spaces.

idebr’s picture

idebr commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

idebr’s picture

idebr commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2979858-10.patch8.15 KB

Reroll after #3090356: Convert tests to phpunit was committed.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new 2979858-10.patch8.15 KB

Rerolled (sorta, was easier to just redo from scratch)

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

LOL, only just saw that I didn't refresh the page before uploading and that the reroll was already done! Ignore #11

But that does allow me to review this :D

So, looks great!

  • Berdir committed 5693128 on 8.x-1.x authored by idebr 
    Issue #2979858 by idebr, Lendude: Use variable placeholder when...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks. This will break existing translations but can't do anything about that, it will also not fix it for people with a customized template, but same, if they did that then the translation worked for them or they fixed it themself there ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.