Closed (fixed)
Project:
Shop Item
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
13 Jun 2018 at 06:45 UTC
Updated:
10 Jul 2018 at 13:14 UTC
Jump to comment: Most recent, Most recent file
Theme has some dependencies due to which it is not installed in the website. So update the README file with all dependencies.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 2979283-12.patch | 407 bytes | gchauhan |
| #10 | 2979283-7.patch | 391 bytes | akash.addweb |
| #6 | 2979283-6.patch | 1.44 KB | yadavarzoo |
| #5 | Issues.png | 117.7 KB | akash.addweb |
| #4 | 2979283-4.patch | 629 bytes | yadavarzoo |
Comments
Comment #2
yadavarzoo commentedThe theme has dependency on Bootstrap theme and commerce module. README is updated.
Comment #3
akash.addweb commented@yadavarzoo, Thank you for the patch but it doesn't work well for me as it doesn't follow the standards for the Readme template. You can refer this link: https://www.drupal.org/docs/develop/documenting-your-project/readme-temp... and also refer the attached screenshot.
Comment #4
yadavarzoo commented@Ronak.addweb, Thankyou for pointing it out. I have updated it.
Comment #5
akash.addweb commented@yadavarzoo, Thank you for the patch again, but still, it doesn't match with Drupal standards. Kindly please refer this attached screenshot for found missing points.
Comment #6
yadavarzoo commentedREADME updated.
Comment #7
akash.addweb commented@yadavarzoo, Thanks for your efforts, I checked it using the ReadMe standards & found 1 small issue in the Configuration section. Need to wrap the text written in configuration by 82 characters.
Comment #8
akash.addweb commentedComment #9
yadavarzoo commented@Ronak.addweb, Could you please add a patch for the issue that you are pointing? I am new to Drupal and I don't understand what is the issue in this readme file. And also see other files in the theme and contribute in making it better.
Comment #10
akash.addweb commented@arzooy97, As per the readme a template standard, here I attached the patch for the change of " Text manually word-wrapped within around 80 cols." You can refer to this patch. Let me know if any query.
Thank you.
Comment #11
akash.addweb commentedComment #12
gchauhan commentedComment #13
gchauhan commentedComment #14
yadavarzoo commented