CommentFileSizeAuthor
#14 2978664-14-migration.patch3.19 KBtrebormc
#13 2978664-13-migration.patch3.59 KBroam2345
#3 2978664-migration.patch3.18 KBtechcodify
#2 2978664-migration.patch1.54 KBtechcodify

Comments

techcodify created an issue. See original summary.

techcodify’s picture

techcodify commented
StatusFileSize
new 2978664-migration.patch1.54 KB

checking process pipeline is an array to eliminate warning messages in migration.

techcodify’s picture

techcodify commented
StatusFileSize
new 2978664-migration.patch3.18 KB

Latest patch file includes fix for Invalid argument warning in another location in Migration php.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Project: Drupal.org site moderators » Drupal core
Version: » 8.6.x-dev
Component: User account » migration system
Assigned: techcodify » Unassigned
quietone’s picture

quietone commented
Issue tags: +Needs issue summary update
Related issues: +#2886349: Invalid argument supplied for foreach() Migration.php:352

@techcodify, Welcome to Drupal! Thanks for the patch too.

The issue summary should state what problem is the patch is to solve. What were you doing and the time and where there any error messages? Providing steps to reproduce the problem will help anyone looking into this issue. If you haven't seen it there is documentation for creating issues that you may find helpful.

Tagging for IS update and adding related issue.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

waverate’s picture

waverate commented

drush migrate:import [MigrationID] returns:

[warning] Invalid argument supplied for foreach() Migration.php:633

Patch #3 fixes it.

Also cleans up migrate:rollback and migrate:status.

@kiamlaluno: Thank you.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

Hmm, i wonder in what circumstances an item is not an array. My gut feeling is that we should look into getProcessNormalized() and do a fix there.

quietone’s picture

quietone commented
Status: Active » Postponed (maintainer needs more info)

@alex.rutz, yes need to know more here.

@techcodify and @waverate, can you provide the process portion of the migration where you got the error so the error can be reproduced? That will be needed to write tests, which are also needed to get a fix committed.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

Looking into the source, i can see several situations where the current code in getProcessNormalized() and getProcessPlugins() will not throw meaningful messages. I guess we will rename this "Provide a meaningful error message for badly configured process plugins".

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

roam2345’s picture

roam2345 commented
StatusFileSize
new 2978664-13-migration.patch3.59 KB

reroll patch no longer applies.

trebormc’s picture

trebormc
Primary language Catalan
commented
StatusFileSize
new 2978664-14-migration.patch3.19 KB

rerolled patch #3 for drupal 8.8.1

hongpong’s picture

hongpong commented

People using wordpress_migrate attempting to generate URL aliases ran into the problem that seems to be related to this thread - I have not checked into this myself yet. (transitioning URLs out of WordPress into Drupal)

See #2904545: Import permalink as URL paths

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Status: Postponed (maintainer needs more info) » Closed (outdated)
Issue tags: +Bug Smash Initiative

As part of the Bug smash initiative, we are triaging issues that are marked 'Postponed (maintainer needs more info)'. It looks like #2969231: errors in migration process configuration don't give a clear message has fixed this and this issue is no longer relevant so I am marking it 'Closed (outdated)'.

quietone’s picture

quietone commented
Issue tags: -Bug Smash Initiative

Sorry for the noise, this wasn't a bug, removing tag.