Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.$ grep -rn views_preprocess_page .
./core/modules/views/views.module:362: * @see views_preprocess_page()
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2978596-removed_non_existent_function-3.patch | 613 bytes | vishalkhode |
Comments
Comment #2
deepalim13 commentedComment #3
vishalkhode commentedUpdated file. Please review patch.
Comment #4
vishalkhode commentedComment #5
msankhala commentedI can confirm the patch applies cleanly and removes the non-existing function views_preprocess_page() mention in @see. Waiting for test bot to pass. once passed ready for RTBC.
Comment #6
msankhala commentedComment #7
alexpott#2352155: Remove HtmlFragment/HtmlPage replaced
views_preprocess_page()withviews_preprocess_html()and #2476947: Convert "title" page element into a block removedviews_preprocess_html()So should we replace the @see with anything?
Comment #8
alexpottI guess the replacement is the call to views_add_contextual_links() in \Drupal\views\Routing\ViewPageController::handle() - so there's no need for an @see there because it's a direct call so IDEs and api docs builders can work that out anyway.
Comment #9
alexpottCrediting @Chi for creating the issue. Other reviewers if you can look at the history like #7/ #8 then you would be credited. You can use
git log -Sto do this, for examplegit log -S "function views_preprocess_page"Comment #10
alexpottCommitted and pushed 3b6be4d7c7 to 8.6.x and eb2b500938 to 8.5.x. Thanks!
Comment #13
msankhala commentedSorry late on this. I am fine if I am not credited on this. I am happy @visshu007 got his first d8 commit mention.