PHP 7.2: count() on non-Countable in views_many_to_one_helper

Thanks!

RTBC+1! Used in Panopoly

Committed. Thanks!

The patch in #2 does not apply to Views 7.x-3.21, here's a re-roll.

The patch in #2 does not apply to Views 7.x-3.23, here's an additional re-roll.

And here is the file mentioned in #9

@DamienMcKenna this commit was reverted by https://git.drupalcode.org/project/views/commit/fbafd79a763f19d8c06039f3...?

This issue was fixed previously with the patch from #2 but we lost it with this commit https://git.drupalcode.org/project/views/commit/fbafd79a763f19d8c06039f3...

@DamienMcKenna please change this ticket back to needs review

I have a similar issue

Error message
Warning: count(): Parameter must be an array or an object that implements Countable in views_handler_argument_term_node_tid_depth->query() (line 110 of drupal7/sites/all/modules/views/modules/taxonomy/views_handler_argument_term_node_tid_depth.inc).

The code in views_handler_argument_term_node_tid_depth.inc should be probably changed in a similar way from

if (count($tids->value) > 1) {

to

if (is_array($tids->value) && count($tids->value) > 1) {

Agreed with #11 and #12, the patch in #2 appears to have been unintentionally reverted when the 7.x-3.21 security updates were merged into the 7.x-3.x branch.

A maintainer should re-open and probably set to 'Needs review' for the patch in #14.

Whoops.

PSA: this is why we need moar test coverage (-:

End of security support for PHP 7.1 is about five weeks ago. Any way this patch could be in a release before then?

Updating patch with a bit of optimisation.

This line doesn't need the extra brackets around the is_array() statement:

if ((is_array($value)) && (count($value) > 1)) {

Cheers @DamienMcKenna.
Updated patch.

Rerolled.

Let's fix this for the next release.

How about this? I'm reverting part of the change in the hopes of limiting what causes problems, we can deal with other count() problems in another issue.

Ok, this more limited change passes for both 7.4 and 8.0, so that's sufficient for now.

Hi Damien, the patch for this issue released in 7.x-3.26 appears to be causing some problems (please see Views 7.x-3.26 breaks glossary view of taxonomy terms causing "SQLSTATE[42000]: Syntax error or access violation: 1064).

I see how patch #27 attempts to simplify the logic, but it doesn't take into account the case if $value is a nested array. The original logic did that, but the problem with the original logic is that it didn't test is_array($value) before calling count($value).

Here is a patch that reverts back to the original logic, but adds is_array($value), which solves the original issue of 'count() on non-Countable'. The patch also implements demonde's suggestion in #13 to make the same correction in views_handler_argument_term_node_tid_depth.inc.

Just saw another potential issue with the original logic. Here's an updated patch.

One more patch also incorporating a correction to views_handler_argument_term_node_tid_depth_join.inc that VladimirAus had made in #21.

Patch #32 does not work for me for the 7.x-3.26 release for the glossary bug my team is experiencing (more info in duplicate issue: https://www.drupal.org/project/views/issues/3305385)

Uploading a patch that fixes this error, from one of Damien's commits.

@ethomas08: Please clarify what happens when you tried #32, in what way did it not work?

Committed. Again. Thank you.