Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In reviewing #2831944: Implement media source plugin for remote video via oEmbed @phenaphroxima discovered a confusion of thumbnail URI and URL. URLs are a subset of URI and in HEAD there's only place where we use thumbnail_url - so let's not.
Proposed resolution
We need to work out what to do about \Drupal\media\Plugin\Field\FieldFormatter\MediaThumbnailFormatter::getMediaThumbnailUrl()
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#2 | 2977250-2.patch | 861 bytes | alexpott |
Comments
Comment #2
alexpottComment #3
alexpottSo \Drupal\media\Plugin\Field\FieldFormatter\MediaThumbnailFormatter::getMediaThumbnailUrl() is tricky because it is the URL for a thumbnail to link to. It is not the URL of a thumbnail :)
Comment #4
phenaproximaRTBC once this passes tests.
Comment #5
catchCommitted d95a6b0 and pushed to 8.6.x. Thanks!