Problem/Motivation

In reviewing #2831944: Implement media source plugin for remote video via oEmbed @phenaphroxima discovered a confusion of thumbnail URI and URL. URLs are a subset of URI and in HEAD there's only place where we use thumbnail_url - so let's not.

Proposed resolution

We need to work out what to do about \Drupal\media\Plugin\Field\FieldFormatter\MediaThumbnailFormatter::getMediaThumbnailUrl()

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2977250-2.patch861 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2977250-2.patch861 bytes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

So \Drupal\media\Plugin\Field\FieldFormatter\MediaThumbnailFormatter::getMediaThumbnailUrl() is tricky because it is the URL for a thumbnail to link to. It is not the URL of a thumbnail :)

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

RTBC once this passes tests.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed d95a6b0 and pushed to 8.6.x. Thanks!

  • catch committed d95a6b0 on 8.6.x 
    Issue #2977250 by alexpott: Media subsystem 99% of time uses thumbnail...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.