Problem/Motivation

To make it easier for other developers to contribute code, let's update Domain to follow the Drupal coding standards. This process can then be tested automatically using travis.

This is part of #2976556: [meta] Follow Drupal coding standards, add phpcs to travis and is scoped to the 'Domain source' (domain_source) submodule.

Proposed resolution

Update the code in 'Domain source' (domain_source) submodule to follow Drupal coding standards.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 domain-source_coding_standards-2976899-2.patch28.07 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new domain-source_coding_standards-2976899-2.patch28.07 KB

Attached patch updates the Domain Source to follow the Drupal coding standards.

idebr’s picture

idebr commented
Status: Needs review » Active

Active development takes place on Github: https://github.com/agentrickard/domain/pull/420

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Sooooooo much easier to review!

Do we need to type hint for other form callback vars? (See GitHub comments.)

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Fixed

This has been committed.

  • 2099643 committed on 8.x-1.x 
    Revert "Issue #2976899 by idebr: [Domain source] Follow Drupal coding...
  • 28ec808 committed on 8.x-1.x
    Issue #2976899 by idebr: [Domain source] Follow Drupal coding standards
  • ef7c164 committed on 8.x-1.x
    Issue #2976899 by idebr: [Domain source] Follow Drupal coding standards
  • agentrickard authored f312c80 on 8.x-1.x
    Merge pull request #420 from ideb/2976899-domain-source-coding-standards...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.