Convert query string to array for d6 menu_link migration

I have been able to reproduce the error with the test fixture by running a full migration, I did it from /upgrade, from a D8 site created from a standard install and all translation modules enabled. After the migration navigating to
/admin/structure/menu/manage/secondary-links?destination=/admin/structure/menu shows this warning

Warning: array_walk() expects parameter 1 to be array, string given in Drupal\Core\Utility\LinkGenerator->generate() (line 119 of core/lib/Drupal/Core/Utility/LinkGenerator.php).

Drupal\Core\Utility\LinkGenerator->generate('Test 2', Object) (Line: 94)
Drupal\Core\Render\Element\Link::preRenderLink(Array)

This is the same error I was getting when the data from the other patch was used, although it was reporting an error on the link added by that patch, that is it wasn't 'Test 2'. Still it is the same problem. The failure occurs on the two menu links that in the source db have a langcode in the options column. The only menu_links with a langcode are mlid 138 and 463, shown below.

MariaDB [dev2_dump]> select mlid, plid, menu_name, link_title, options  from menu_links where plid=139 or mlid=139 order by plid;
MariaDB [dev2_dump]> select mlid, plid, menu_name, link_title, router_path, options  from menu_links where plid=139 or mlid=139 order by plid;
+------+------+-----------------+-------------+-------------+-----------------------------------------------------------------------------------------------------------------+
| mlid | plid | menu_name       | link_title  | router_path | options                                                                                                         |
+------+------+-----------------+-------------+-------------+-----------------------------------------------------------------------------------------------------------------+
|  139 |    0 | secondary-links | Test 2      | admin       | a:2:{s:5:"query";s:7:"foo=bar";s:10:"attributes";a:1:{s:5:"title";s:16:"Test menu link 2";}}                    |
|  138 |  139 | secondary-links | Test 1      | user/login  | a:2:{s:10:"attributes";a:1:{s:5:"title";s:16:"Test menu link 1";}s:8:"langcode";s:2:"en";}                      |
|  463 |  139 | secondary-links | fr - Test 1 | user/login  | a:3:{s:10:"attributes";a:1:{s:5:"title";s:21:"fr - Test menu link 1";}s:8:"langcode";s:2:"fr";s:5:"alter";b:1;} |
+------+------+-----------------+-------------+-------------+-----------------------------------------------------------------------------------------------------------------+

Both menu links 138 and 463 have been migrated with a langcode of 'en'.

Also, there is another problem. Two menu links, the links to the two translated nodes, fail to migrate. The destid is NULL and 3 is the row status in the map table.

The path "internal:/node/11" failed validation.
The path "internal:/node/13" failed validation.

I am not familiar with the node translation migration. Is this intended or should those links have been skipped?

There are several things causing problems.

1) The array walk problem is caused because the query parameter is a string instead of an array in link/options. This may be a simple fix.
The migration simply copies the options array as is from Drupal 6 to link/options, 'link/options': options, where the query parameter is a string. Fortunately, the route plugin converts the query options to an array, so it might work to just simply move the link/options migration to after the route process plugin and change it to 'link/options': '@route/options'.
I tested with that and the only change to link/options was making the query parameters and array instead of string and there is no more warning message.

2) A French only menu link is migrated as 'en' because the langcode field in the options array is ignored. It will be simple to check that but it needs to work correctly for sites with and without language enabled.

3) The menu_links for the translated nodes are migrated as NULL and errors in the migrate_map. Can these be skipped instead so there is not error?

Here is a fix for the original problem. The solution is to convert the query options from D6, which is a string, to an array.

There are two other problems that are identified in #3. They should be in a separate issue, or they are a duplicate of an existing one. I have not checked.

Tested with the D6 fixture and this works fine and the admin page the secondary menu link loads without error. Test passes locally too.

Oh, I didn't notice that it was the Translation test that failed.

This patch updates the Translation tests and includes some comment fixes.

This is at least a major

#20.1 Regarding the points in #3, you are right I didn't comment on them (although I thought I had).

• 3.1 Fixed in this patch
• 3.2 Followup is #3245553: Fix migration of localized D6 menu links .
• 3.3 A brief look at skipping these rows seemed overly complicated. I think it would be better to spend time on #3051251: Existing menu links show validation issues on migration (and ALL menu links pointing to node translations are invalid).

#20.2. I changed an existing test link in the D7 fixture to have query options and added that to the existing D7 test. It turns out that D7 stores the query options as an array instead of a string as in D6. So, no code changes are needed there. I have remade the fail patch to show that Drupal 7 tests for the query options pass without code changes.

Forgot to upload the fail patch. Starting over.

That is odd, I didn't change the status.

The fail patch contains a test for Drupal 7 and it passes, only the Drupal 6 tests fail, which is as expected.

So, the patch in #21 is the patch in #16 with the addition of test coverage for Drupal 7. And the issue summary was updated. I think that covers everything in #20.

Sure. And here is the fix for the comment.

I disagree. This patch improves the testing for Drupal 7 migrations and changes the fixture and a test file it does not change any code that executes migrations for Drupal 7 source.

Restoring title. It will match the commit message now.