Currently, when using the 'Single' and 'Manual' preview mode of the 'Enable previews when adding panes' there's something that make it a little harder to use with a screenreader.

  • The links to show the preview don't make it clear either that a preview is being shown, or which widget they are showing the preview for
  • The keyboard focus jumps back to the first link in the modal after the preview is activated rather than jumping into the preview so it's read by the screenreader

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

Status: Active » Needs work
StatusFileSize
new1.52 KB

Here's a patch that attempts to fix the first bullet point with some invisible text in the preview links.

The second bullet point is going to be trickier.

dsnopek’s picture

StatusFileSize
new4.38 KB

Here's the start of a patch that monkeypatches the CTools ajax command to replace the modal in order to adjust the focus on preview. It doesn't totally work yet, but it does get all the information we'll need to adjust the focus, and its run at a time that I think will allow adjusting it.

dsnopek’s picture

Status: Needs work » Needs review
StatusFileSize
new5.26 KB

Ok, here's one that works enough to review! This puts the focus on the first focusable element within the preview (which is the "Add" button) for both the single and manual preview modes.

dsnopek’s picture

Status: Needs review » Needs work

Hm. I've been testing this in an environment with Radix, but it seems to fail on vanilla Panopoly...

dsnopek’s picture

Status: Needs work » Needs review
StatusFileSize
new7.85 KB

Here's a new version of the patch which is cleaned up, and works for me on both vanilla Panopoly and with Radix.

cboyden’s picture

dsnopek’s picture

StatusFileSize
new7.85 KB
new1.61 KB

Apparently, the tricky stuff I was doing with spaces around the hidden, screenreader-only text was confusing screenreaders in testing. Here's a new patch that doesn't do that - the output should be the same for sighted users.

dsnopek’s picture

Here's a Travis build just to double check that all is good:

https://travis-ci.org/panopoly/panopoly/builds/397028809

  • dsnopek committed a867aa7 on 7.x-1.x
    Update Panopoly Magic for Issue #2975454 by dsnopek, cboyden: Improve...
dsnopek’s picture

Status: Needs review » Fixed

Tests passed! Committed upstream :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.