Closed (fixed)
Project:
Panopoly
Version:
7.x-1.x-dev
Component:
Magic
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 May 2018 at 03:26 UTC
Updated:
12 Jul 2018 at 02:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dsnopekHere's a patch that attempts to fix the first bullet point with some invisible text in the preview links.
The second bullet point is going to be trickier.
Comment #3
dsnopekHere's the start of a patch that monkeypatches the CTools ajax command to replace the modal in order to adjust the focus on preview. It doesn't totally work yet, but it does get all the information we'll need to adjust the focus, and its run at a time that I think will allow adjusting it.
Comment #4
dsnopekOk, here's one that works enough to review! This puts the focus on the first focusable element within the preview (which is the "Add" button) for both the single and manual preview modes.
Comment #5
dsnopekHm. I've been testing this in an environment with Radix, but it seems to fail on vanilla Panopoly...
Comment #6
dsnopekHere's a new version of the patch which is cleaned up, and works for me on both vanilla Panopoly and with Radix.
Comment #7
cboyden commentedComment #8
dsnopekApparently, the tricky stuff I was doing with spaces around the hidden, screenreader-only text was confusing screenreaders in testing. Here's a new patch that doesn't do that - the output should be the same for sighted users.
Comment #9
dsnopekHere's a Travis build just to double check that all is good:
https://travis-ci.org/panopoly/panopoly/builds/397028809
Comment #11
dsnopekTests passed! Committed upstream :-)